Skip to content

Local provider jobs run through sandboxes and add subprocess monitoring#1671

Merged
deep1401 merged 16 commits intomainfrom
add/sanboxes
Mar 31, 2026
Merged

Local provider jobs run through sandboxes and add subprocess monitoring#1671
deep1401 merged 16 commits intomainfrom
add/sanboxes

Conversation

@deep1401
Copy link
Copy Markdown
Member

No description provided.

@sentry
Copy link
Copy Markdown

sentry bot commented Mar 27, 2026

@paragon-review
Copy link
Copy Markdown

Paragon Summary

This pull request review identified 4 issues across 4 categories in 3 files. The review analyzed code changes, potential bugs, security vulnerabilities, performance issues, and code quality concerns using automated analysis tools.

This PR routes local provider jobs through sandboxed execution instead of running them directly, improving isolation for local job runs. It also updates the local provider setup to support the sandbox workflow end to end.

Key changes:

  • Local provider jobs now run through sandboxes instead of the old path
  • Added a new sandbox.py compute-provider component
  • Updated local.py to route local provider job execution via sandbox handling
  • Adjusted local provider conda install script for the new sandbox-based flow

Confidence score: 2/5

  • This PR has high risk due to 1 critical issue that require immediate attention before merge
  • Score reflects critical security vulnerabilities, data loss risks, or system stability issues
  • Pay close attention to critical findings and address them before proceeding

3 files reviewed, 4 comments

Severity breakdown: Critical: 1, High: 1, Medium: 1, Low: 1


Tip: @paragon-run <instructions> to chat with our agent or push fixes!

Dashboard

@aliasaria
Copy link
Copy Markdown
Member

Would it be helpful to use the bwrap wrapper bubblejail? Some reading I did said it will prevent some issues by wrapping bwrap and prevent the issues mentioned above -- kinds of bugs a maintained library would have already caught.

@aliasaria aliasaria changed the title Local provider jobs run through sanboxes Local provider jobs run through sandboxes Mar 27, 2026
@deep1401 deep1401 changed the title Local provider jobs run through sandboxes Local provider jobs run through sandboxes and add subprocess monitoring Mar 27, 2026
@deep1401
Copy link
Copy Markdown
Member Author

Would it be helpful to use the bwrap wrapper bubblejail? Some reading I did said it will prevent some issues by wrapping bwrap and prevent the issues mentioned above -- kinds of bugs a maintained library would have already caught.

Okay I didnt know about bubblejail will check that out

@deep1401
Copy link
Copy Markdown
Member Author

Would it be helpful to use the bwrap wrapper bubblejail? Some reading I did said it will prevent some issues by wrapping bwrap and prevent the issues mentioned above -- kinds of bugs a maintained library would have already caught.

Ended up sticking with bubblewrap because the others seemed to be nicer if we wanted a more high level GUI solution. Since we have static flags for our sandbox, I ended up sticking with bwrap for more low level access

@aliasaria aliasaria self-requested a review March 31, 2026 16:07
@deep1401 deep1401 merged commit 0b29486 into main Mar 31, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants