Move jobs within the experiment folder and make calls faster#1607
Move jobs within the experiment folder and make calls faster#1607
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
deep1401
changed the title
dadmobile
left a comment
dadmobile
left a comment
There was a problem hiding this comment.
Havne't tested yet. But found some things with job_get that might cause issues?
| if not resolved_job_id: | ||
| return None | ||
|
|
||
| key = _job_cache_key(resolved_job_id) |
There was a problem hiding this comment.
Just calling this out as I'm not 100% I'm following...
In the get function this makes sure to resolve the job_id to to the full value but in job_update_status it uses the passed job_id, which I'm not sure if it will definitely be the resolved full ID or not?
There was a problem hiding this comment.
It wont get to that case because I think we use full ids everywhere for cache writes and the read comes through Job.get which would need the full id so there wont be duplicated cache entries?
| Disable auto-migration when `TFL_DISABLE_MIGRATE_JOBS=1` (or true-ish). | ||
|
|
||
| Also supports a legacy/alternative value: | ||
| - `TFL_DISABLE_MIGRATE=jobs` |
There was a problem hiding this comment.
It didnt exist before but I just added it as a dev thing incase someone wanted to use. Should I get rid of it?
There was a problem hiding this comment.
Oh I meant that for some reason there are two variables? TFL_DISABLE_MIGRATE_JOB and TFL_DISABLE_MIGRATE?
There was a problem hiding this comment.
Its only 1. The comment is wrong. I'll fix. I'll actually just remove the variable altogether, we dont need it now. It was only for me
dadmobile
left a comment
dadmobile
left a comment
There was a problem hiding this comment.
I got this (NaN) while trying to view files? In case it matters the job failed (with the error I sent you) and confirmed in the network bar that it was trying to call http://localhost:8338/experiment/AWStest/jobs/NaN/files?subpath=:
|
(Also same issue for provider logs as for file browser) |
deep1401
left a comment
deep1401
left a comment
There was a problem hiding this comment.
I got this (NaN) while trying to view files? In case it matters the job failed (with the error I sent you) and confirmed in the network bar that it was trying to call
http://localhost:8338/experiment/AWStest/jobs/NaN/files?subpath=:
There were multiple parseInt(jobid) calls in the frontend. I fixed all of them. It should be fixed now, could check once more for the same job please?
dadmobile
left a comment
dadmobile
left a comment
There was a problem hiding this comment.
It seems like it is putting my old jobs at the top of the job history list?
I think thats probably because it tries to sort by id first, will fix |
deep1401
left a comment
deep1401
left a comment
There was a problem hiding this comment.
It seems like it is putting my old jobs at the top of the job history list?
Okay so I fixed the sorting now and its two-fold. Jobs are sorted by either of created_at or started_at fields
dadmobile
left a comment
dadmobile
left a comment
There was a problem hiding this comment.
Temporarily rescinding approval while I try to figure out a better way to do the migration (or I don't and we just move forward).
2 participants
No description provided.