Improve CLI code quality and maintainability#1606
Merged
Conversation
- Add missing api.post_text() method (fixes broken task add from directory) - Remove unused `requests` dependency from pyproject.toml - Use centralized themed console from util/ui.py across all command files (11 duplicate Console() instances removed) - Replace 28 bare `except Exception` blocks with specific exceptions (httpx.HTTPError, ValueError, KeyError, LookupError, OSError) - Remove debug print() statements from TUI job monitor that corrupt terminal - Complete theme migration: replace hardcoded Rich color tags ([red], [cyan], [green], [yellow]) with theme tokens ([error], [label], [success], [warning]) and remove migration tracking comments - Fix textual version mismatch in pyproject.toml (0.40.0 -> 0.86.0) - Clean up redundant CLIState.get_instance() singleton pattern - Extract hardcoded default server URL into shared constant - Add timeout constants to util/shared.py - Add test coverage: conftest.py with shared fixtures, tests for config CRUD, URL validation, provider commands, and login/logout flows (37 total tests) - Fix broken test_job.py mocks (patching wrong attribute path) - Remove dead log_to_file() function from JobDetails.py https://claude.ai/code/session_01LKvUQvK8szsQLNSzXnV1FT
Merge origin/main into the CLI quality branch, combining: - JSON output format support and new features from main - Themed console and custom style names from this branch - Fix test mocks to use require_current_experiment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requestsdependency from pyproject.tomlexcept Exceptionblocks with specific exceptions (httpx.HTTPError, ValueError, KeyError, LookupError, OSError)