Skip to content

Cache experiments list#1600

Merged
deep1401 merged 10 commits intomainfrom
fix/caching-exp-list
Mar 23, 2026
Merged

Cache experiments list#1600
deep1401 merged 10 commits intomainfrom
fix/caching-exp-list

Conversation

@deep1401
Copy link
Copy Markdown
Member

No description provided.

@paragon-review
Copy link
Copy Markdown

Paragon Review Skipped

Hi @deep1401! Your Polarity credit balance is insufficient to complete this review.

Please visit https://home.polarity.cc to add more credits and continue using Paragon reviews.

dadmobile
dadmobile previously approved these changes Mar 20, 2026
@sentry
Copy link
Copy Markdown

sentry bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 18.86792% with 43 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
api/transformerlab/services/experiment_service.py 18.86% 43 Missing ⚠️

📢 Thoughts on this report? Let us know!

@deep1401 deep1401 requested a review from dadmobile March 20, 2026 18:59
@deep1401 deep1401 dismissed dadmobile’s stale review March 20, 2026 18:59

Cancelling your approval because I made a major change just when you approved

@deep1401 deep1401 requested a review from dadmobile March 20, 2026 20:08
Copy link
Copy Markdown
Member

@dadmobile dadmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about the one logger thing. Otherwise looks good.

from transformerlab.services.cache_service import cache, cached

logger = logging.getLogger(__name__)
_tlab_log_level = os.getenv("TLAB_LOG_LEVEL", "").upper()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should have to do this? Was there a bug?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed now

@deep1401 deep1401 requested a review from dadmobile March 23, 2026 16:17
@deep1401 deep1401 merged commit e62ca42 into main Mar 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants