Conversation
|
Paragon Review Skipped Hi @deep1401! Your Polarity credit balance is insufficient to complete this review. Please visit https://home.polarity.cc to add more credits and continue using Paragon reviews. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
|
||
|
|
||
| @router.get("/model/list") | ||
| @cached(key="models:list:{embedding}", ttl="7d", tags=["models", "models:list"]) |
There was a problem hiding this comment.
This might be one we can't put a long TTL on because you can add models via SDK?
There was a problem hiding this comment.
The models via sdk get added in the job only now. And you need to manually save it to registry right?
There was a problem hiding this comment.
Okay so the ModelsLocalList right now is only called on the View Models component to check if a model with a similar name exists or not.
This is still fine I believe if the caching is long because the only time we'd add a model to the models list would be through save to registry?
There was a problem hiding this comment.
Oh I might not understand this now. So if you do a lab.save_model (or whatever the call is) that doesn't go to the team's model list? That just saved for the job and you have to use the UI to save to the model list?
There was a problem hiding this comment.
Yes, we used to save it directly to model list earlier but now it goes to a separate place and you have to sort of promote it to be a model
2 participants
No description provided.