Fix provider logs showing new content in the middle#1539
Merged
Conversation
… bottom LocalProvider.get_job_logs concatenated stdout then stderr, so static setup stderr (git hints, pip output) was always at the bottom while new runtime stdout appeared above it. Swap the order to stderr-first so growing stdout content appends at the end. Also replace raw ANSI escape sequences with xterm.js native reset() and fix scrollToBottom in PollingOutputTerminal.
|
Paragon Review Skipped Hi @aliasaria! Your Polarity credit balance is insufficient to complete this review. Please visit https://home.polarity.cc to add more credits and continue using Paragon reviews. |
deep1401
approved these changes
Mar 12, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocalProvider.get_job_logsconcatenated stdout then stderr. Since stderr contains static setup messages (git hints, pip install) and stdout grows with runtime output, new log lines appeared in the middle instead of at the bottom.\x1b[2J\x1b[H) with xterm.js nativeterminal.reset()and fixscrollToBottom()inPollingOutputTerminal.Test plan