Skip to content

Add custom sbatch flags per-user per slurm provider and edit during runs#1451

Merged
deep1401 merged 5 commits intomainfrom
add/custom-sbatch-flags
Mar 6, 2026
Merged

Add custom sbatch flags per-user per slurm provider and edit during runs#1451
deep1401 merged 5 commits intomainfrom
add/custom-sbatch-flags

Conversation

@deep1401
Copy link
Copy Markdown
Member

@deep1401 deep1401 commented Mar 4, 2026

@paragon-review
Copy link
Copy Markdown

paragon-review bot commented Mar 4, 2026

Paragon Summary

This pull request review analyzed 5 files and found no issues. The review examined code changes, potential bugs, security vulnerabilities, performance issues, and code quality concerns using automated analysis tools.

Paragon did not detect any problems in the current diff. Proceed with merge after your normal checks.

This PR adds the ability for users to configure custom sbatch flags per Slurm compute provider, with support for editing these flags even while runs are in progress, addressing issue #1447.

Key changes:

  • Added per-user custom sbatch flags configuration for Slurm providers
  • Enabled editing of sbatch flags during active runs
  • Updated backend (slurm.py, provider_service.py) to store and apply custom flags
  • Added API endpoints in compute_provider.py for managing user-specific flags
  • Enhanced UI in QueueTaskModal and ProviderSettingsSection for flag management

Confidence score: 5/5

  • This PR has low risk with no critical or high-priority issues identified
  • Score reflects clean code review with only minor suggestions or no issues found
  • Code quality checks passed - safe to proceed with merge

5 files reviewed, 0 comments


Tip: @paragon-run <instructions> to chat with our agent or push fixes!

Dashboard

@sentry
Copy link
Copy Markdown

sentry bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
api/transformerlab/routers/compute_provider.py 0.00% 27 Missing ⚠️
api/transformerlab/compute_providers/slurm.py 0.00% 25 Missing ⚠️
api/transformerlab/services/provider_service.py 0.00% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

@deep1401 deep1401 merged commit eb78680 into main Mar 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need support for custom #SBATCH directives in the Slurm provider

2 participants