Skip to content

Remove RAG reindex functionality from Documents UI and backend#1428

Merged
aliasaria merged 3 commits intomainfrom
remove-rag-reindex
Mar 3, 2026
Merged

Remove RAG reindex functionality from Documents UI and backend#1428
aliasaria merged 3 commits intomainfrom
remove-rag-reindex

Conversation

@aliasaria
Copy link
Copy Markdown
Member

@aliasaria aliasaria commented Mar 3, 2026

Summary

Removes all RAG reindex functionality and the "rag" folder concept from the Documents UI and backend.

Frontend

  • Removed the "Reindex" button from the Documents component
  • Removed the "Documents for RAG should be uploaded in a folder called rag" message
  • Removed the additionalMessage prop from the Documents component
  • Cleaned up unused imports (RotateCcwIcon, TinyButton)
  • Removed Rag.ReIndex endpoint from the API client

Backend

  • Removed commented-out rag.reindex() calls from document upload, upload_links, and download_zip handlers
  • Removed /experiment/{experimentId}/rag/reindex from openapi.json

Summary by CodeRabbit

  • Changes

    • Removed the Reindex button from the Documents interface.
  • Chores

    • Removed obsolete API endpoints and commented code related to document reindexing.

@paragon-review
Copy link
Copy Markdown

paragon-review bot commented Mar 3, 2026

Paragon Summary

This pull request review analyzed 5 files and found no issues. The review examined code changes, potential bugs, security vulnerabilities, performance issues, and code quality concerns using automated analysis tools.

Paragon did not detect any problems in the current diff. Proceed with merge after your normal checks.

This PR removes the RAG reindex functionality entirely from both the frontend Documents UI (removing the Reindex button and rag folder messaging) and the backend API (cleaning up reindex handler code and removing the endpoint from the OpenAPI spec).

Key changes:

  • Removed "Reindex" button and "rag" folder message from Documents UI components
  • Cleaned up unused imports (RotateCcwIcon, TinyButton) and additionalMessage prop
  • Removed Rag.ReIndex endpoint from API client
  • Removed commented-out rag.reindex() calls from document upload handlers
  • Removed /experiment/{experimentId}/rag/reindex endpoint from OpenAPI spec

Confidence score: 5/5

  • This PR has low risk with no critical or high-priority issues identified
  • Score reflects clean code review with only minor suggestions or no issues found
  • Code quality checks passed - safe to proceed with merge

5 files reviewed, 0 comments


Tip: @paragon-run <instructions> to chat with our agent or push fixes!

Dashboard

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ef9754 and 47d82c8.

⛔ Files ignored due to path filters (1)
  • scripts/openapi.json is excluded by !**/*.json
📒 Files selected for processing (4)
  • api/transformerlab/routers/experiment/documents.py
  • src/renderer/components/Experiment/Documents/index.tsx
  • src/renderer/components/Shared/Documents/index.tsx
  • src/renderer/lib/api-client/endpoints.ts
💤 Files with no reviewable changes (3)
  • src/renderer/lib/api-client/endpoints.ts
  • src/renderer/components/Shared/Documents/index.tsx
  • api/transformerlab/routers/experiment/documents.py

📝 Walkthrough

Walkthrough

This PR removes RAG reindexing functionality across the codebase. Commented-out reindex calls are eliminated from the backend documents router, the Rag.ReIndex endpoint is removed from the API client endpoints, and the Documents component no longer exposes the additionalMessage prop or renders a Reindex button with explanatory messaging.

Changes

Cohort / File(s) Summary
Backend RAG Reindexing
api/transformerlab/routers/experiment/documents.py
Removed commented-out rag.reindex() calls that previously suggested reindexing the vector store after uploads or ZIP extraction.
API Client Endpoints
src/renderer/lib/api-client/endpoints.ts
Removed Rag.ReIndex public endpoint method from the Endpoints.Rag object.
Frontend UI Components
src/renderer/components/Shared/Documents/index.tsx, src/renderer/components/Experiment/Documents/index.tsx
Removed additionalMessage prop from Documents component signature and its parent usage; eliminated Reindex button UI block, related handler, and RotateCcwIcon and TinyButton imports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Remove a lot of API routes #1391: Both PRs modify RAG reindexing code paths, removing or commenting out rag.reindex() calls in the documents router and the Rag.ReIndex endpoint in the renderer.

Suggested reviewers

  • deep1401
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove RAG reindex functionality from Documents UI and backend' directly and accurately summarizes the main objective of the changeset, clearly communicating the primary purpose of the pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-rag-reindex

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sentry
Copy link
Copy Markdown

sentry bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@aliasaria aliasaria merged commit c708a38 into main Mar 3, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants