Skip to content

Remove lingering workflows stuff#1420

Merged
deep1401 merged 6 commits intomainfrom
fix/remove-lingering-workflows
Mar 2, 2026
Merged

Remove lingering workflows stuff#1420
deep1401 merged 6 commits intomainfrom
fix/remove-lingering-workflows

Conversation

@deep1401
Copy link
Copy Markdown
Member

@deep1401 deep1401 commented Mar 2, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

Release Notes

  • Refactor
    • Simplified database initialization by consolidating workflow-related migrations into the standard migration process, reducing startup complexity.
    • Removed workflow-related API endpoints from the client interface.
    • Cleaned up test coverage and removed workflow-specific test cases.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 2, 2026 •
edited
Loading

Warning

Rate limit exceeded

@deep1401 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 49 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 678deec and 10dd968.

📒 Files selected for processing (1)
  • api/test/db/test_db.py
📝 Walkthrough

Walkthrough

The PR removes workflow-related functionality from tests, database session initialization, and the API endpoint client. This includes deletion of the TestWorkflows test class, the non-preserving workflow migration function, and the complete Workflows endpoint builder interface.

Changes

Cohort / File(s) Summary
Test Coverage Removal
api/test/db/test_db.py		 Removed TestWorkflows class and all workflow-related test methods; deleted imports for job_service and workflow modules. Retained only configuration-related tests.
Database Session Migration
api/transformerlab/db/session.py		 Removed migrate_workflows_non_preserving() function and its invocation from init() method; simplified startup flow to rely solely on Alembic migrations.
API Endpoints
src/renderer/lib/api-client/endpoints.ts		 Removed entire Endpoints.Workflows public interface containing all workflow-related endpoint builders (ListInExperiment, CreateEmpty, UpdateName, RunWorkflow, etc.).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • transformerlab-app#1385: Removes additional workflow-related runtime and API pieces including background job processing and workflow imports.

Suggested reviewers

  • aliasaria
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title uses vague language ('lingering workflows stuff') that doesn't clearly convey what specific changes are being made, making it difficult to understand the scope and impact. Use a more descriptive title that clearly specifies the changes, such as 'Remove workflow-related code and tests' or 'Remove workflows API and database migration code'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/remove-lingering-workflows

Comment @coderabbitai help to get the list of available commands and usage tips.

@paragon-review
Copy link
Copy Markdown

paragon-review bot commented Mar 2, 2026

Paragon Summary

This pull request review analyzed 3 files and found no issues. The review examined code changes, potential bugs, security vulnerabilities, performance issues, and code quality concerns using automated analysis tools.

Paragon did not detect any problems in the current diff. Proceed with merge after your normal checks.

This PR removes leftover workflow-related code from the codebase, cleaning up the database session layer, associated tests, and frontend API endpoints.

Key changes:

  • Based on the limited information provided (PR title and file list only):
  • Removes workflow-related code from 3 files across test, database, and frontend layers
  • Modified test file: api/test/db/test_db.py
  • Modified database session handling: api/transformerlab/db/session.py
  • Updated frontend API endpoints: src/renderer/lib/api-client/endpoints.ts

Confidence score: 5/5

  • This PR has low risk with no critical or high-priority issues identified
  • Score reflects clean code review with only minor suggestions or no issues found
  • Code quality checks passed - safe to proceed with merge

3 files reviewed, 0 comments

Tip: @paragon-run <instructions> to chat with our agent or push fixes!

Dashboard

@deep1401 deep1401 merged commit 3b0c49c into main Mar 2, 2026
8 checks passed
@sentry
Copy link
Copy Markdown

sentry bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paragon-review paragon-review[bot] paragon-review[bot] left review comments

@dadmobile dadmobile dadmobile approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deep1401 @dadmobile