Conversation
Contributor
📝 WalkthroughWalkthroughThis PR refactors the exporter job wrapper architecture by consolidating Changes
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@api/transformerlab/plugin_sdk/transformerlab/sdk/v1/export.py`:
- Line 1: The job_wrapper function is missing type annotations for its **kwargs
parameter and its return type; update the signature of job_wrapper in export.py
(the function named job_wrapper) to annotate **kwargs with an appropriate
Mapping/Dict type (e.g., **kwargs: Any or **kwargs: Mapping[str, Any]) and add a
return type hint matching the actual return (e.g., -> Any or the concrete return
type), and import Any/Mapping from typing if needed to satisfy type checking.
In `@api/transformerlab/plugin_sdk/transformerlab/sdk/v1/tlab_plugin.py`:
- Line 12: The function job_wrapper is a decorator factory missing a return
type; update its signature to declare it returns a callable decorator (e.g., use
typing.Callable or a TypeVar: Callable[[Callable[..., Any]], Callable[..., Any]]
or more generically Callable[..., Callable[..., Any]]). Locate job_wrapper in
tlab_plugin.py and add the appropriate return type annotation (or use TypeVar F
and annotate as -> Callable[[F], F]) while keeping the existing parameter type
hints.
| import traceback | ||
|
|
||
| from transformerlab.sdk.v1.tlab_plugin import TLabPlugin, DotDict, _run_async_from_sync | ||
| from transformerlab.sdk.v1.tlab_plugin import TLabPlugin, DotDict |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# First, check if the file exists and read its content
if [ -f "api/transformerlab/plugin_sdk/transformerlab/sdk/v1/export.py" ]; then
echo "=== File Content ==="
cat -n "api/transformerlab/plugin_sdk/transformerlab/sdk/v1/export.py"
else
echo "File not found"
find . -name "export.py" -type f | head -20
fiRepository: transformerlab/transformerlab-app
Length of output: 2298
🏁 Script executed:
#!/bin/bash
# Run the verification script from the review comment
python - <<'PY'
import ast, pathlib
try:
path = pathlib.Path("api/transformerlab/plugin_sdk/transformerlab/sdk/v1/export.py")
content = path.read_text()
tree = ast.parse(content)
print("=== Searching for job_wrapper function ===")
found = False
for node in ast.walk(tree):
if isinstance(node, ast.FunctionDef) and node.name == "job_wrapper":
found = True
print(f"Function: {node.name}")
print(f"Line: {node.lineno}")
print(f"Return annotation: {node.returns}")
print(f"Arguments:")
for arg in node.args.args:
print(f" {arg.arg}: {arg.annotation}")
if node.args.kwarg:
print(f" **{node.args.kwarg.arg}: {node.args.kwarg.annotation}")
print()
if not found:
print("job_wrapper function not found")
print("\n=== All function definitions in file ===")
for node in ast.walk(tree):
if isinstance(node, ast.FunctionDef):
print(f" {node.name} at line {node.lineno}")
except FileNotFoundError:
print("File not found at path")
except Exception as e:
print(f"Error: {e}")
PYRepository: transformerlab/transformerlab-app
Length of output: 322
Add type annotations for job_wrapper function parameters and return type.
The job_wrapper method at lines 39-43 is missing type annotations for **kwargs and the return type, which violates the requirement to include mandatory type hints for all function arguments and return types in Python code.
Proposed fix
+from typing import Any, Callable
from transformerlab.sdk.v1.tlab_plugin import TLabPlugin, DotDict
def job_wrapper(self, progress_start: int = 0, progress_end: int = 100, **kwargs):
+ def job_wrapper(
+ self,
+ progress_start: int = 0,
+ progress_end: int = 100,
+ **kwargs: Any,
+ ) -> Callable[[Callable[..., Any]], Callable[..., Any]]:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@api/transformerlab/plugin_sdk/transformerlab/sdk/v1/export.py` at line 1, The
job_wrapper function is missing type annotations for its **kwargs parameter and
its return type; update the signature of job_wrapper in export.py (the function
named job_wrapper) to annotate **kwargs with an appropriate Mapping/Dict type
(e.g., **kwargs: Any or **kwargs: Mapping[str, Any]) and add a return type hint
matching the actual return (e.g., -> Any or the concrete return type), and
import Any/Mapping from typing if needed to satisfy type checking.
| import json | ||
| from pydantic import BaseModel | ||
| from typing import Any, List | ||
| from typing import Any, List, Optional |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n "api/transformerlab/plugin_sdk/transformerlab/sdk/v1/tlab_plugin.py" | head -20Repository: transformerlab/transformerlab-app
Length of output: 740
🏁 Script executed:
sed -n '1,15p' "api/transformerlab/plugin_sdk/transformerlab/sdk/v1/tlab_plugin.py" | cat -nRepository: transformerlab/transformerlab-app
Length of output: 498
🏁 Script executed:
sed -n '95,115p' "api/transformerlab/plugin_sdk/transformerlab/sdk/v1/tlab_plugin.py" | cat -nRepository: transformerlab/transformerlab-app
Length of output: 983
Add a return type annotation to job_wrapper.
The function at lines 99-107 is missing a return type annotation. All parameters have type hints, but the return type is absent, which violates the mandatory type-hinting guideline. The function is a decorator factory, so it should declare that it returns a callable that accepts a callable and returns a callable.
Proposed fix
-from typing import Any, List, Optional
+from typing import Any, Callable, List, Optional def job_wrapper(
self,
progress_start: int = 0,
progress_end: int = 100,
wandb_project_name: str = "TLab_Training",
manual_logging: bool = False,
success_message: Optional[str] = None,
include_exception_in_error: bool = False,
- ):
+ ) -> Callable[[Callable[..., Any]], Callable[..., Any]]:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@api/transformerlab/plugin_sdk/transformerlab/sdk/v1/tlab_plugin.py` at line
12, The function job_wrapper is a decorator factory missing a return type;
update its signature to declare it returns a callable decorator (e.g., use
typing.Callable or a TypeVar: Callable[[Callable[..., Any]], Callable[..., Any]]
or more generically Callable[..., Callable[..., Any]]). Locate job_wrapper in
tlab_plugin.py and add the appropriate return type annotation (or use TypeVar F
and annotate as -> Callable[[F], F]) while keeping the existing parameter type
hints.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
dadmobile
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Refactor
Chores