verify: public method should not expose private type#147
Merged
DarkaMaul merged 1 commit intotrailofbits:mainfrom May 15, 2025
Merged
verify: public method should not expose private type#147DarkaMaul merged 1 commit intotrailofbits:mainfrom
DarkaMaul merged 1 commit intotrailofbits:mainfrom
Conversation
This is technically an API change but seems to be the real intent of the API: _Verifier is not part of public API so the return value of a public method should not be _Verifier.
DarkaMaul
approved these changes
May 15, 2025
Collaborator
|
Yes - good call here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is technically an API change but seems to be the real intent of the API:
_Verifieris not part of public API so the return value of a public method should not be_Verifier.