interp: improve handling of empty interface values#1393
Merged
Conversation
At variable, function parameter, slice, map or field element assign, if the destination type is an empty interface, the value was never wrapped into a valueInterface (to preserve type mutability in case of re-assign). Now we wrap it in a valueInterface if the source type has a non empty set of methods, to allow a future use as a non empty interface. There are still corner cases, but it extends notably the support of interfaces within the interpreter. Fixes traefik#1355.
Collaborator
Author
|
Yes, the issue is testing only function call, but we have to cover consistently (at least for maintainability) the other possible cases where an interpreter non empty interface value can be assigned to an empty interface value. I agree that we may miss unit tests for those cases. |
mpl
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At variable, function parameter, slice, map or field element assign,
if the destination type is an empty interface, the value was never
wrapped into a valueInterface (to preserve type mutability in case
of re-assign). Now we wrap it in a valueInterface if the source
type has a non empty set of methods, to allow a future use as a non
empty interface.
There are still corner cases, but it extends notably the support
of interfaces within the interpreter.
Fixes #1355.