Ignore other gateways parentRefs and update route parent statuses only for managed gateways by rtribotte · Pull Request #13397 · traefik/traefik

rtribotte · 2026-06-24T14:00:58Z

What does this PR do?

This PR fixes two behaviors:

ignore other gateways parentRefs when building route configuration and statuses
update route parent statuses only for managed gateways

Motivation

To fix the Gateway API provider behavior.

More

Added/updated tests
Added/updated documentation

Additional Notes

Assisted-by: Claude Opus 4.8 (1M context)

Copilot

Pull request overview

This PR updates the Kubernetes Gateway API provider to (1) ignore parentRefs that point to Gateways not managed by Traefik and (2) update Route parent statuses only for Gateways Traefik manages, while preserving other controllers’ (and other Traefik instances’) existing status entries.

Changes:

Refactors route loading (HTTP/GRPC/TCP/TLS) to match parentRefs against the set of managed Gateways and compute statuses only for those parents.
Updates Route status writes to merge newly computed parent statuses with existing “non-owned” statuses.
Adds fixtures and tests covering multi-parentRefs scenarios (managed + foreign Gateway), including attached route counting and status preservation.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pkg/provider/kubernetes/gateway/httproute.go	Loads HTTPRoutes only for managed Gateway parentRefs; updates parent status write path accordingly.
pkg/provider/kubernetes/gateway/grpcroute.go	Same as HTTPRoute, applied to GRPCRoutes.
pkg/provider/kubernetes/gateway/tcproute.go	Same as HTTPRoute, applied to TCPRoutes (experimental channel).
pkg/provider/kubernetes/gateway/tlsroute.go	Same as HTTPRoute, applied to TLSRoutes (experimental channel).
pkg/provider/kubernetes/gateway/kubernetes.go	Introduces `gatewayWithListeners` and parentRef-to-managed-Gateway matching helper.
pkg/provider/kubernetes/gateway/client.go	Adds `mergeRouteParentStatuses` and threads managed-gateways context into Route status updates.
pkg/provider/kubernetes/gateway/kubernetes_test.go	Adds/updates unit tests for parentRef matching and multi-gateway parentRef status/attached-route behavior.
pkg/provider/kubernetes/gateway/fixtures/httproute/with_multiple_gateways_parent_refs.yml	New fixture covering HTTPRoute referencing both managed and foreign Gateways.
pkg/provider/kubernetes/gateway/fixtures/grpcroute/with_multiple_gateways_parent_refs.yml	New fixture covering GRPCRoute referencing both managed and foreign Gateways.
pkg/provider/kubernetes/gateway/fixtures/tcproute/with_multiple_gateways_parent_refs.yml	New fixture covering TCPRoute referencing both managed and foreign Gateways.
pkg/provider/kubernetes/gateway/fixtures/tlsroute/with_multiple_gateways_parent_refs.yml	New fixture covering TLSRoute referencing both managed and foreign Gateways.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…s only for managed gateways

traefiker · 2026-06-26T08:34:03Z

🚫 error related to review: need more review [0/2]

mmatur

LGTM

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [traefik](https://github.com/containous/traefik) | patch | `v3.7.5` → `v3.7.6` | --- > ⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/12) for more information. --- ### Release Notes <details> <summary>containous/traefik (traefik)</summary> ### [`v3.7.6`](https://github.com/containous/traefik/blob/HEAD/CHANGELOG.md#v376-2026-06-30) [Compare Source](traefik/traefik@v3.7.6...v3.7.6) [All Commits](traefik/traefik@v3.7.5...v3.7.6) **Bug fixes:** - **\[acme, logs]** Bump github.com/go-acme/lego/v5 ([#13154](traefik/traefik#13154) [@ldez](https://github.com/ldez)) - **\[acme]** Bump github.com/go-acme/lego/v5 ([#13359](traefik/traefik#13359) [@juliens](https://github.com/juliens)) - **\[k8s, k8s/ingress-nginx]** Fix ingress-nginx ssl passthrough status updates ([#13212](traefik/traefik#13212) [@nickmnt](https://github.com/nickmnt)) - **\[k8s/gatewayapi]** Add missing Gateway API features in conformance tests ([#13356](traefik/traefik#13356) [@AnatoleLucet](https://github.com/AnatoleLucet)) - **\[k8s/gatewayapi]** Avoid collisions for Gateway API services names ([#13367](traefik/traefik#13367) [@rtribotte](https://github.com/rtribotte)) - **\[k8s/gatewayapi]** Ignore other gateways parentRefs and update route parent statuses only for managed gateways ([#13397](traefik/traefik#13397) [@rtribotte](https://github.com/rtribotte)) - **\[k8s/ingress-nginx]** Configure retry according to buffering configuration ([#13039](traefik/traefik#13039) [@rtribotte](https://github.com/rtribotte)) - **\[k8s/ingress-nginx]** Fix force-ssl-redirect routing 418 when TLS is terminated upstream ([#13386](traefik/traefik#13386) [@carloslima](https://github.com/carloslima)) - **\[k8s]** Detect EndpointSlice condition changes ([#13405](traefik/traefik#13405) [@kevinpollet](https://github.com/kevinpollet)) - **\[k8s]** Index Kubernetes EndpointSlice by service name ([#13395](traefik/traefik#13395) [@kevinpollet](https://github.com/kevinpollet)) - **\[k8s]** Sort endpointslices to keep backend IPs consistent across rebuilds ([#13406](traefik/traefik#13406) [@kevinpollet](https://github.com/kevinpollet)) - **\[kv]** Bump kvtools/redis to v1.2.1 ([#13403](traefik/traefik#13403) [@ldez](https://github.com/ldez)) - **\[middleware, authentication]** Fix x-forwarded-port in forward-auth ([#13344](traefik/traefik#13344) [@juliens](https://github.com/juliens)) - **\[middleware, k8s/gatewayapi]** Fix Gateway API redirect missing statuses ([#13360](traefik/traefik#13360) [@AnatoleLucet](https://github.com/AnatoleLucet)) - **\[middleware, k8s/gatewayapi]** Fix Host header not being modified by RequestHeaderModifier ([#12805](traefik/traefik#12805) [@mihuross](https://github.com/mihuross)) - **\[middleware, k8s/gatewayapi]** Fix request scheme derivation when Gateway API RequestRedirect omits scheme ([#13347](traefik/traefik#13347) [@gndz07](https://github.com/gndz07)) - **\[middleware]** Fix CORS Max-Age set to 0 by default ([#13371](traefik/traefik#13371) [@AnatoleLucet](https://github.com/AnatoleLucet)) - **\[middleware]** Fix CORS wildcard when allow-credentials is true ([#13368](traefik/traefik#13368) [@AnatoleLucet](https://github.com/AnatoleLucet)) - **\[server]** Add an option to remove request headers with underscores ([#13262](traefik/traefik#13262) [@youkoulayley](https://github.com/youkoulayley)) - **\[server]** Configurable max request header size ([#13353](traefik/traefik#13353) [@juliens](https://github.com/juliens)) - **\[tls]** Fix nondeterministic TLS certificate selection on shared SAN ([#13348](traefik/traefik#13348) [@rtribotte](https://github.com/rtribotte)) - **\[webui]** Bump axios to v1.18.0 ([#13380](traefik/traefik#13380) [@gndz07](https://github.com/gndz07)) - **\[websocket]** Fix connection upgrades when backend server is using h2c scheme ([#12967](traefik/traefik#12967) [@stffabi](https://github.com/stffabi)) **Documentation:** - **\[k8s/crd]** Fix broken CRD reference links in IngressRoute page ([#13375](traefik/traefik#13375) [@s3onghyun](https://github.com/s3onghyun)) - **\[k8s/gatewayapi]** Remove experimental note for Gateway API/TLSRoute documentation ([#13392](traefik/traefik#13392) [@jnoordsij](https://github.com/jnoordsij)) - **\[k8s/ingress-nginx]** Add Kubernetes Ingress NGINX to the providers list ([#13372](traefik/traefik#13372) [@nmengin](https://github.com/nmengin)) - **\[k8s]** Align Helm chart documented values with chart v41 ([#13366](traefik/traefik#13366) [@mloiseleur](https://github.com/mloiseleur)) - **\[middleware, authentication, k8s/ingress-nginx]** Clarify intentional auth-response-headers gating and absence of stripping incoming X-Forwarded-\* headers ([#13342](traefik/traefik#13342) [@rtribotte](https://github.com/rtribotte)) - **\[middleware]** Clarify entryPoint middleware reference format ([#13364](traefik/traefik#13364) [@mloiseleur](https://github.com/mloiseleur)) - **\[security]** Add HTTP/2 header memory exhaustion security documentation ([#13381](traefik/traefik#13381) [@emilevauge](https://github.com/emilevauge)) - Adds documentations on maxHeaderBytes ([#13363](traefik/traefik#13363) [@juliens](https://github.com/juliens)) - Fix inaccuracies in reference documentation ([#13304](traefik/traefik#13304) [@sheddy-traefik](https://github.com/sheddy-traefik)) ### [`v3.7.6`](https://github.com/containous/traefik/blob/HEAD/CHANGELOG.md#v376-2026-06-30) [Compare Source](traefik/traefik@v3.7.5...v3.7.6) [All Commits](traefik/traefik@v3.7.5...v3.7.6) **Bug fixes:** - **\[acme, logs]** Bump github.com/go-acme/lego/v5 ([#13154](traefik/traefik#13154) [@ldez](https://github.com/ldez)) - **\[acme]** Bump github.com/go-acme/lego/v5 ([#13359](traefik/traefik#13359) [@juliens](https://github.com/juliens)) - **\[k8s, k8s/ingress-nginx]** Fix ingress-nginx ssl passthrough status updates ([#13212](traefik/traefik#13212) [@nickmnt](https://github.com/nickmnt)) - **\[k8s/gatewayapi]** Add missing Gateway API features in conformance tests ([#13356](traefik/traefik#13356) [@AnatoleLucet](https://github.com/AnatoleLucet)) - **\[k8s/gatewayapi]** Avoid collisions for Gateway API services names ([#13367](traefik/traefik#13367) [@rtribotte](https://github.com/rtribotte)) - **\[k8s/gatewayapi]** Ignore other gateways parentRefs and update route parent statuses only for managed gateways ([#13397](traefik/traefik#13397) [@rtribotte](https://github.com/rtribotte)) - **\[k8s/ingress-nginx]** Configure retry according to buffering configuration ([#13039](traefik/traefik#13039) [@rtribotte](https://github.com/rtribotte)) - **\[k8s/ingress-nginx]** Fix force-ssl-redirect routing 418 when TLS is terminated upstream ([#13386](traefik/traefik#13386) [@carloslima](https://github.com/carloslima)) - **\[k8s]** Detect EndpointSlice condition changes ([#13405](traefik/traefik#13405) [@kevinpollet](https://github.com/kevinpollet)) - **\[k8s]** Index Kubernetes EndpointSlice by service name ([#13395](traefik/traefik#13395) [@kevinpollet](https://github.com/kevinpollet)) - **\[k8s]** Sort endpointslices to keep backend IPs consistent across rebuilds ([#13406](traefik/traefik#13406) [@kevinpollet](https://github.com/kevinpollet)) - **\[kv]** Bump kvtools/redis to v1.2.1 ([#13403](traefik/traefik#13403) [@ldez](https://github.com/ldez)) - **\[middleware, authentication]** Fix x-forwarded-port in forward-auth ([#13344](traefik/traefik#13344) [@juliens](https://github.com/juliens)) - **\[middleware, k8s/gatewayapi]** Fix Gateway API redirect missing statuses ([#13360](traefik/traefik#13360) [@AnatoleLucet](https://github.com/AnatoleLucet)) - **\[middleware, k8s/gatewayapi]** Fix Host header not being modified by RequestHeaderModifier ([#12805](traefik/traefik#12805) [@mihuross](https://github.com/mihuross)) - **\[middleware, k8s/gatewayapi]** Fix request scheme derivation when Gateway API RequestRedirect omits scheme ([#13347](traefik/traefik#13347) [@gndz07](https://github.com/gndz07)) - **\[middleware]** Fix CORS Max-Age set to 0 by default ([#13371](traefik/traefik#13371) [@AnatoleLucet](https://github.com/AnatoleLucet)) - **\[middleware]** Fix CORS wildcard when allow-credentials is true ([#13368](traefik/traefik#13368) [@AnatoleLucet](https://github.com/AnatoleLucet)) - **\[server]** Add an option to remove request headers with underscores ([#13262](traefik/traefik#13262) [@youkoulayley](https://github.com/youkoulayley)) - **\[server]** Configurable max request header size ([#13353](traefik/traefik#13353) [@juliens](https://github.com/juliens)) - **\[tls]** Fix nondeterministic TLS certificate selection on shared SAN ([#13348](traefik/traefik#13348) [@rtribotte](https://github.com/rtribotte)) - **\[webui]** Bump axios to v1.18.0 ([#13380](traefik/traefik#13380) [@gndz07](https://github.com/gndz07)) - **\[websocket]** Fix connection upgrades when backend server is using h2c scheme ([#12967](traefik/traefik#12967) [@stffabi](https://github.com/stffabi)) **Documentation:** - **\[k8s/crd]** Fix broken CRD reference links in IngressRoute page ([#13375](traefik/traefik#13375) [@s3onghyun](https://github.com/s3onghyun)) - **\[k8s/gatewayapi]** Remove experimental note for Gateway API/TLSRoute documentation ([#13392](traefik/traefik#13392) [@jnoordsij](https://github.com/jnoordsij)) - **\[k8s/ingress-nginx]** Add Kubernetes Ingress NGINX to the providers list ([#13372](traefik/traefik#13372) [@nmengin](https://github.com/nmengin)) - **\[k8s]** Align Helm chart documented values with chart v41 ([#13366](traefik/traefik#13366) [@mloiseleur](https://github.com/mloiseleur)) - **\[middleware, authentication, k8s/ingress-nginx]** Clarify intentional auth-response-headers gating and absence of stripping incoming X-Forwarded-\* headers ([#13342](traefik/traefik#13342) [@rtribotte](https://github.com/rtribotte)) - **\[middleware]** Clarify entryPoint middleware reference format ([#13364](traefik/traefik#13364) [@mloiseleur](https://github.com/mloiseleur)) - **\[security]** Add HTTP/2 header memory exhaustion security documentation ([#13381](traefik/traefik#13381) [@emilevauge](https://github.com/emilevauge)) - Adds documentations on maxHeaderBytes ([#13363](traefik/traefik#13363) [@juliens](https://github.com/juliens)) - Fix inaccuracies in reference documentation ([#13304](traefik/traefik#13304) [@sheddy-traefik](https://github.com/sheddy-traefik)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.jfreudenberger.de/JuliusFreudenberger/nix-config/pulls/16 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

rtribotte added this to the 3.6 milestone Jun 24, 2026

rtribotte added status/2-needs-review kind/bug/fix a bug fix area/provider/k8s/gatewayapi labels Jun 24, 2026

traefiker added area/provider/k8s size/L labels Jun 24, 2026

rtribotte removed the area/provider/k8s label Jun 24, 2026

rtribotte requested a review from Copilot June 25, 2026 12:10

Copilot started reviewing on behalf of rtribotte June 25, 2026 12:11 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread pkg/provider/kubernetes/gateway/httproute.go

Comment thread pkg/provider/kubernetes/gateway/grpcroute.go

Comment thread pkg/provider/kubernetes/gateway/tcproute.go

Comment thread pkg/provider/kubernetes/gateway/tlsroute.go

rtribotte force-pushed the fix-parentrefs branch from 06c1c77 to 367332a Compare June 25, 2026 14:16

kevinpollet force-pushed the fix-parentrefs branch from 367332a to e53e1e0 Compare June 25, 2026 14:40

mmatur self-requested a review June 26, 2026 07:31

rtribotte and others added 6 commits June 26, 2026 10:32

fix: ignore other gateways parentRefs and update route parent statuse…

3fbdb54

…s only for managed gateways

review

173c289

review

8abf564

review

7dc2746

review

1bf6c91

review

337860f

kevinpollet force-pushed the fix-parentrefs branch from 9b40af8 to 337860f Compare June 26, 2026 08:32

kevinpollet added status/3-needs-merge and removed status/2-needs-review labels Jun 26, 2026

traefiker added the bot/need-human-merge label Jun 26, 2026

mmatur approved these changes Jun 26, 2026

View reviewed changes

kevinpollet approved these changes Jun 26, 2026

View reviewed changes

mmatur removed the bot/need-human-merge label Jun 26, 2026

traefiker merged commit 32bb716 into traefik:v3.6 Jun 26, 2026
63 of 66 checks passed

traefiker removed the status/3-needs-merge label Jun 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Ignore other gateways parentRefs and update route parent statuses only for managed gateways#13397

Ignore other gateways parentRefs and update route parent statuses only for managed gateways#13397
traefiker merged 6 commits into
traefik:v3.6from
rtribotte:fix-parentrefs

rtribotte commented Jun 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

traefiker commented Jun 26, 2026

Uh oh!

mmatur left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

rtribotte commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

More

Additional Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

traefiker commented Jun 26, 2026

Uh oh!

mmatur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rtribotte commented Jun 24, 2026 •

edited

Loading