Fix snicheck for routers with no hosts#13333
Merged
Merged
Conversation
rtribotte
added
status/2-needs-review
kind/bug/fix
emilevauge
reviewed
Jun 10, 2026
emilevauge
left a comment
emilevauge
left a comment
Member
There was a problem hiding this comment.
Thanks, this addresses the follow-ups from #13329 precisely.
Two points to settle before merging, in my opinion:
- Log severity. The conflict is now logged at
Errorlevel, while before #13291 it was aWarn. The behavior is a functional fallback (the routers still serve traffic with the default options), not a failure, and users monitoring the error level may start alerting on it. IfErroris the deliberate choice (it is a misconfiguration after all), fine, but it should be a conscious decision. - Migration note. The
ep-conflicted-namerenaming is visible in the API, the dashboard, metrics labels and access logs for conflicted routers. The docs checkbox is unchecked; a short note underdocs/content/migration/would save support some tickets.
juliens
approved these changes
Jun 10, 2026
kevinpollet
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the SNICheck mechanism for routers with no hosts that are already configured to use the default TLSOptions. It also improves logging for detected conflicts, and mitigate (not fully) possible collisions in naming of the conflicted routers.
Motivation
Follow up to #13329
More
Additional Notes
Co-authored-by: Gina A. [email protected]