Skip to content

Pass endpointslice fencing on ingress-nginx provider#13290

Merged
traefiker merged 2 commits into
traefik:v3.7from
Learloj:bugfix/13287-fix-ingress-nginx-endpointslice-fencing
Jun 9, 2026
Merged

Pass endpointslice fencing on ingress-nginx provider#13290
traefiker merged 2 commits into
traefik:v3.7from
Learloj:bugfix/13287-fix-ingress-nginx-endpointslice-fencing

Conversation

@Learloj

@Learloj Learloj commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes when endpointslice is updated, marking an endpoint as ready: false and terminating: true, Traefik's ingress-nginx provider marks the server as fenced and stops sending new traffic to it.

Motivation

We want our pods to be able to gracefully terminate, and to do so, they should stop receiving new requests and be able to handle existing requests, until done and then stop. Right now, they get traffic when they are in Terminating state, until they are fully stopped, which sometimes results in requests being sent to a pod which is already stopped, resulting in HTTP timeouts towards the client.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Fixes #13287

@traefiker traefiker added this to the 3.7 milestone Jun 3, 2026
@Learloj Learloj changed the title kubernetes ingress-nginx: pass endpointslice fencing bugfix: kubernetes ingress-nginx: pass endpointslice fencing Jun 3, 2026
@nmengin

nmengin commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Hey @Learloj,
Thanks for this contribution!
We've set this to "review" and will take a look at the code.
We'll update you once the review is done.

@rtribotte rtribotte added kind/bug/fix a bug fix and removed area/provider/k8s labels Jun 8, 2026
@gndz07 gndz07 changed the title bugfix: kubernetes ingress-nginx: pass endpointslice fencing Pass endpointslice fencing on ingress-nginx provider Jun 8, 2026
@gndz07
gndz07 force-pushed the bugfix/13287-fix-ingress-nginx-endpointslice-fencing branch 3 times, most recently from 6384ec5 to a8869f8 Compare June 8, 2026 15:33
@gndz07
gndz07 force-pushed the bugfix/13287-fix-ingress-nginx-endpointslice-fencing branch from a8869f8 to 965daee Compare June 8, 2026 15:33

@gndz07 gndz07 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rtribotte rtribotte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@traefiker
traefiker merged commit d5ad3eb into traefik:v3.7 Jun 9, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants