Configure retry according to buffering configuration#13039
Merged
Conversation
rtribotte
force-pushed
the
fix-retry-maxbody
branch
from
April 24, 2026 14:18
c247e6e to
811f2c9
Compare
kevinpollet
previously approved these changes
Apr 24, 2026
rtribotte
force-pushed
the
fix-retry-maxbody
branch
from
May 4, 2026 13:15
5937308 to
f3ec915
Compare
rtribotte
force-pushed
the
fix-retry-maxbody
branch
from
June 2, 2026 08:04
2548b19 to
f8d6c6d
Compare
gndz07
requested changes
Jun 3, 2026
rtribotte
force-pushed
the
fix-retry-maxbody
branch
from
June 15, 2026 13:47
5c5e5e5 to
629613a
Compare
There was a problem hiding this comment.
Pull request overview
This PR aligns Traefik’s retry behavior with ingress-nginx semantics by (1) wiring retry request-body buffering limits to the proxy-body-size annotation, and (2) constraining status-code retries when request buffering is disabled (proxy-request-buffering: "off"). It also refines the retry middleware’s internal “network error” gating to avoid retrying responses produced before the request reaches the proxy layer.
Changes:
- ingress-nginx provider: set
Retry.MaxRequestBodyBytesfromproxy-body-sizeand restrict body retries when request buffering is disabled. - retry middleware: replace the old
ContextShouldRetrymechanism with explicit “proxy reached” and “request wrote” signaling, and adjust large-body behavior to disable HTTP-status retry instead of returning 413. - tests/fixtures: add new ingress fixtures and update expected dynamic configs and retry middleware tests.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/provider/kubernetes/ingress-nginx/middleware.go | Derives retry buffering limits from proxy-body-size and restricts body retries when request buffering is disabled. |
| pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go | Updates expected retry configs and adds coverage for new buffering/retry interactions. |
| pkg/provider/kubernetes/ingress-nginx/fixtures/ingresses/*.yml | Adds fixtures for proxy-request-buffering, proxy-body-size, and status-only retry scenarios. |
| pkg/middlewares/retry/retry.go | Refactors network-error retry gating and changes behavior when request bodies exceed buffer limits. |
| pkg/middlewares/retry/retry_test.go | Updates existing tests and adds cases for proxy-not-reached vs status-based retry behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+454
to
+458
| if maxRequestBodyBytes == 0 { | ||
| // Zero value means no limit with ingress-nginx. | ||
| // With the retry middleware, the equivalent configuration is a negative value. | ||
| maxRequestBodyBytes = -1 | ||
| } |
kevinpollet
approved these changes
Jun 22, 2026
kevinpollet
force-pushed
the
fix-retry-maxbody
branch
from
June 22, 2026 09:45
4b5f2eb to
5e84f7f
Compare
2 tasks
JuliusFreudenberger
pushed a commit
to JuliusFreudenberger/nix-config
that referenced
this pull request
Jul 2, 2026
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [traefik](https://github.com/containous/traefik) | patch | `v3.7.5` → `v3.7.6` | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/12) for more information. --- ### Release Notes <details> <summary>containous/traefik (traefik)</summary> ### [`v3.7.6`](https://github.com/containous/traefik/blob/HEAD/CHANGELOG.md#v376-2026-06-30) [Compare Source](traefik/traefik@v3.7.6...v3.7.6) [All Commits](traefik/traefik@v3.7.5...v3.7.6) **Bug fixes:** - **\[acme, logs]** Bump github.com/go-acme/lego/v5 ([#​13154](traefik/traefik#13154) [@​ldez](https://github.com/ldez)) - **\[acme]** Bump github.com/go-acme/lego/v5 ([#​13359](traefik/traefik#13359) [@​juliens](https://github.com/juliens)) - **\[k8s, k8s/ingress-nginx]** Fix ingress-nginx ssl passthrough status updates ([#​13212](traefik/traefik#13212) [@​nickmnt](https://github.com/nickmnt)) - **\[k8s/gatewayapi]** Add missing Gateway API features in conformance tests ([#​13356](traefik/traefik#13356) [@​AnatoleLucet](https://github.com/AnatoleLucet)) - **\[k8s/gatewayapi]** Avoid collisions for Gateway API services names ([#​13367](traefik/traefik#13367) [@​rtribotte](https://github.com/rtribotte)) - **\[k8s/gatewayapi]** Ignore other gateways parentRefs and update route parent statuses only for managed gateways ([#​13397](traefik/traefik#13397) [@​rtribotte](https://github.com/rtribotte)) - **\[k8s/ingress-nginx]** Configure retry according to buffering configuration ([#​13039](traefik/traefik#13039) [@​rtribotte](https://github.com/rtribotte)) - **\[k8s/ingress-nginx]** Fix force-ssl-redirect routing 418 when TLS is terminated upstream ([#​13386](traefik/traefik#13386) [@​carloslima](https://github.com/carloslima)) - **\[k8s]** Detect EndpointSlice condition changes ([#​13405](traefik/traefik#13405) [@​kevinpollet](https://github.com/kevinpollet)) - **\[k8s]** Index Kubernetes EndpointSlice by service name ([#​13395](traefik/traefik#13395) [@​kevinpollet](https://github.com/kevinpollet)) - **\[k8s]** Sort endpointslices to keep backend IPs consistent across rebuilds ([#​13406](traefik/traefik#13406) [@​kevinpollet](https://github.com/kevinpollet)) - **\[kv]** Bump kvtools/redis to v1.2.1 ([#​13403](traefik/traefik#13403) [@​ldez](https://github.com/ldez)) - **\[middleware, authentication]** Fix x-forwarded-port in forward-auth ([#​13344](traefik/traefik#13344) [@​juliens](https://github.com/juliens)) - **\[middleware, k8s/gatewayapi]** Fix Gateway API redirect missing statuses ([#​13360](traefik/traefik#13360) [@​AnatoleLucet](https://github.com/AnatoleLucet)) - **\[middleware, k8s/gatewayapi]** Fix Host header not being modified by RequestHeaderModifier ([#​12805](traefik/traefik#12805) [@​mihuross](https://github.com/mihuross)) - **\[middleware, k8s/gatewayapi]** Fix request scheme derivation when Gateway API RequestRedirect omits scheme ([#​13347](traefik/traefik#13347) [@​gndz07](https://github.com/gndz07)) - **\[middleware]** Fix CORS Max-Age set to 0 by default ([#​13371](traefik/traefik#13371) [@​AnatoleLucet](https://github.com/AnatoleLucet)) - **\[middleware]** Fix CORS wildcard when allow-credentials is true ([#​13368](traefik/traefik#13368) [@​AnatoleLucet](https://github.com/AnatoleLucet)) - **\[server]** Add an option to remove request headers with underscores ([#​13262](traefik/traefik#13262) [@​youkoulayley](https://github.com/youkoulayley)) - **\[server]** Configurable max request header size ([#​13353](traefik/traefik#13353) [@​juliens](https://github.com/juliens)) - **\[tls]** Fix nondeterministic TLS certificate selection on shared SAN ([#​13348](traefik/traefik#13348) [@​rtribotte](https://github.com/rtribotte)) - **\[webui]** Bump axios to v1.18.0 ([#​13380](traefik/traefik#13380) [@​gndz07](https://github.com/gndz07)) - **\[websocket]** Fix connection upgrades when backend server is using h2c scheme ([#​12967](traefik/traefik#12967) [@​stffabi](https://github.com/stffabi)) **Documentation:** - **\[k8s/crd]** Fix broken CRD reference links in IngressRoute page ([#​13375](traefik/traefik#13375) [@​s3onghyun](https://github.com/s3onghyun)) - **\[k8s/gatewayapi]** Remove experimental note for Gateway API/TLSRoute documentation ([#​13392](traefik/traefik#13392) [@​jnoordsij](https://github.com/jnoordsij)) - **\[k8s/ingress-nginx]** Add Kubernetes Ingress NGINX to the providers list ([#​13372](traefik/traefik#13372) [@​nmengin](https://github.com/nmengin)) - **\[k8s]** Align Helm chart documented values with chart v41 ([#​13366](traefik/traefik#13366) [@​mloiseleur](https://github.com/mloiseleur)) - **\[middleware, authentication, k8s/ingress-nginx]** Clarify intentional auth-response-headers gating and absence of stripping incoming X-Forwarded-\* headers ([#​13342](traefik/traefik#13342) [@​rtribotte](https://github.com/rtribotte)) - **\[middleware]** Clarify entryPoint middleware reference format ([#​13364](traefik/traefik#13364) [@​mloiseleur](https://github.com/mloiseleur)) - **\[security]** Add HTTP/2 header memory exhaustion security documentation ([#​13381](traefik/traefik#13381) [@​emilevauge](https://github.com/emilevauge)) - Adds documentations on maxHeaderBytes ([#​13363](traefik/traefik#13363) [@​juliens](https://github.com/juliens)) - Fix inaccuracies in reference documentation ([#​13304](traefik/traefik#13304) [@​sheddy-traefik](https://github.com/sheddy-traefik)) ### [`v3.7.6`](https://github.com/containous/traefik/blob/HEAD/CHANGELOG.md#v376-2026-06-30) [Compare Source](traefik/traefik@v3.7.5...v3.7.6) [All Commits](traefik/traefik@v3.7.5...v3.7.6) **Bug fixes:** - **\[acme, logs]** Bump github.com/go-acme/lego/v5 ([#​13154](traefik/traefik#13154) [@​ldez](https://github.com/ldez)) - **\[acme]** Bump github.com/go-acme/lego/v5 ([#​13359](traefik/traefik#13359) [@​juliens](https://github.com/juliens)) - **\[k8s, k8s/ingress-nginx]** Fix ingress-nginx ssl passthrough status updates ([#​13212](traefik/traefik#13212) [@​nickmnt](https://github.com/nickmnt)) - **\[k8s/gatewayapi]** Add missing Gateway API features in conformance tests ([#​13356](traefik/traefik#13356) [@​AnatoleLucet](https://github.com/AnatoleLucet)) - **\[k8s/gatewayapi]** Avoid collisions for Gateway API services names ([#​13367](traefik/traefik#13367) [@​rtribotte](https://github.com/rtribotte)) - **\[k8s/gatewayapi]** Ignore other gateways parentRefs and update route parent statuses only for managed gateways ([#​13397](traefik/traefik#13397) [@​rtribotte](https://github.com/rtribotte)) - **\[k8s/ingress-nginx]** Configure retry according to buffering configuration ([#​13039](traefik/traefik#13039) [@​rtribotte](https://github.com/rtribotte)) - **\[k8s/ingress-nginx]** Fix force-ssl-redirect routing 418 when TLS is terminated upstream ([#​13386](traefik/traefik#13386) [@​carloslima](https://github.com/carloslima)) - **\[k8s]** Detect EndpointSlice condition changes ([#​13405](traefik/traefik#13405) [@​kevinpollet](https://github.com/kevinpollet)) - **\[k8s]** Index Kubernetes EndpointSlice by service name ([#​13395](traefik/traefik#13395) [@​kevinpollet](https://github.com/kevinpollet)) - **\[k8s]** Sort endpointslices to keep backend IPs consistent across rebuilds ([#​13406](traefik/traefik#13406) [@​kevinpollet](https://github.com/kevinpollet)) - **\[kv]** Bump kvtools/redis to v1.2.1 ([#​13403](traefik/traefik#13403) [@​ldez](https://github.com/ldez)) - **\[middleware, authentication]** Fix x-forwarded-port in forward-auth ([#​13344](traefik/traefik#13344) [@​juliens](https://github.com/juliens)) - **\[middleware, k8s/gatewayapi]** Fix Gateway API redirect missing statuses ([#​13360](traefik/traefik#13360) [@​AnatoleLucet](https://github.com/AnatoleLucet)) - **\[middleware, k8s/gatewayapi]** Fix Host header not being modified by RequestHeaderModifier ([#​12805](traefik/traefik#12805) [@​mihuross](https://github.com/mihuross)) - **\[middleware, k8s/gatewayapi]** Fix request scheme derivation when Gateway API RequestRedirect omits scheme ([#​13347](traefik/traefik#13347) [@​gndz07](https://github.com/gndz07)) - **\[middleware]** Fix CORS Max-Age set to 0 by default ([#​13371](traefik/traefik#13371) [@​AnatoleLucet](https://github.com/AnatoleLucet)) - **\[middleware]** Fix CORS wildcard when allow-credentials is true ([#​13368](traefik/traefik#13368) [@​AnatoleLucet](https://github.com/AnatoleLucet)) - **\[server]** Add an option to remove request headers with underscores ([#​13262](traefik/traefik#13262) [@​youkoulayley](https://github.com/youkoulayley)) - **\[server]** Configurable max request header size ([#​13353](traefik/traefik#13353) [@​juliens](https://github.com/juliens)) - **\[tls]** Fix nondeterministic TLS certificate selection on shared SAN ([#​13348](traefik/traefik#13348) [@​rtribotte](https://github.com/rtribotte)) - **\[webui]** Bump axios to v1.18.0 ([#​13380](traefik/traefik#13380) [@​gndz07](https://github.com/gndz07)) - **\[websocket]** Fix connection upgrades when backend server is using h2c scheme ([#​12967](traefik/traefik#12967) [@​stffabi](https://github.com/stffabi)) **Documentation:** - **\[k8s/crd]** Fix broken CRD reference links in IngressRoute page ([#​13375](traefik/traefik#13375) [@​s3onghyun](https://github.com/s3onghyun)) - **\[k8s/gatewayapi]** Remove experimental note for Gateway API/TLSRoute documentation ([#​13392](traefik/traefik#13392) [@​jnoordsij](https://github.com/jnoordsij)) - **\[k8s/ingress-nginx]** Add Kubernetes Ingress NGINX to the providers list ([#​13372](traefik/traefik#13372) [@​nmengin](https://github.com/nmengin)) - **\[k8s]** Align Helm chart documented values with chart v41 ([#​13366](traefik/traefik#13366) [@​mloiseleur](https://github.com/mloiseleur)) - **\[middleware, authentication, k8s/ingress-nginx]** Clarify intentional auth-response-headers gating and absence of stripping incoming X-Forwarded-\* headers ([#​13342](traefik/traefik#13342) [@​rtribotte](https://github.com/rtribotte)) - **\[middleware]** Clarify entryPoint middleware reference format ([#​13364](traefik/traefik#13364) [@​mloiseleur](https://github.com/mloiseleur)) - **\[security]** Add HTTP/2 header memory exhaustion security documentation ([#​13381](traefik/traefik#13381) [@​emilevauge](https://github.com/emilevauge)) - Adds documentations on maxHeaderBytes ([#​13363](traefik/traefik#13363) [@​juliens](https://github.com/juliens)) - Fix inaccuracies in reference documentation ([#​13304](traefik/traefik#13304) [@​sheddy-traefik](https://github.com/sheddy-traefik)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNTAuMSIsInVwZGF0ZWRJblZlciI6IjQzLjE1MC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.jfreudenberger.de/JuliusFreudenberger/nix-config/pulls/16 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets the retry middleware's MaxRequestBodyBytes from the proxy-body-size annotation in the ingress-nginx provider, and disable retry when proxy-request-buffering is off.
Motivation
To have a consistent behavior with ingress-nginx.
More
Additional Notes