Skip to content

Configure retry according to buffering configuration#13039

Merged
traefiker merged 19 commits into
traefik:v3.7from
rtribotte:fix-retry-maxbody
Jun 22, 2026
Merged

Configure retry according to buffering configuration#13039
traefiker merged 19 commits into
traefik:v3.7from
rtribotte:fix-retry-maxbody

Conversation

@rtribotte

Copy link
Copy Markdown
Member

What does this PR do?

This PR sets the retry middleware's MaxRequestBodyBytes from the proxy-body-size annotation in the ingress-nginx provider, and disable retry when proxy-request-buffering is off.

Motivation

To have a consistent behavior with ingress-nginx.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

kevinpollet
kevinpollet previously approved these changes Apr 24, 2026
@kevinpollet
kevinpollet dismissed their stale review April 24, 2026 15:16

review found an issue

@rtribotte
rtribotte force-pushed the fix-retry-maxbody branch from 5937308 to f3ec915 Compare May 4, 2026 13:15
@rtribotte
rtribotte force-pushed the fix-retry-maxbody branch from 2548b19 to f8d6c6d Compare June 2, 2026 08:04
Comment thread pkg/middlewares/retry/retry.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns Traefik’s retry behavior with ingress-nginx semantics by (1) wiring retry request-body buffering limits to the proxy-body-size annotation, and (2) constraining status-code retries when request buffering is disabled (proxy-request-buffering: "off"). It also refines the retry middleware’s internal “network error” gating to avoid retrying responses produced before the request reaches the proxy layer.

Changes:

  • ingress-nginx provider: set Retry.MaxRequestBodyBytes from proxy-body-size and restrict body retries when request buffering is disabled.
  • retry middleware: replace the old ContextShouldRetry mechanism with explicit “proxy reached” and “request wrote” signaling, and adjust large-body behavior to disable HTTP-status retry instead of returning 413.
  • tests/fixtures: add new ingress fixtures and update expected dynamic configs and retry middleware tests.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pkg/provider/kubernetes/ingress-nginx/middleware.go Derives retry buffering limits from proxy-body-size and restricts body retries when request buffering is disabled.
pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go Updates expected retry configs and adds coverage for new buffering/retry interactions.
pkg/provider/kubernetes/ingress-nginx/fixtures/ingresses/*.yml Adds fixtures for proxy-request-buffering, proxy-body-size, and status-only retry scenarios.
pkg/middlewares/retry/retry.go Refactors network-error retry gating and changes behavior when request bodies exceed buffer limits.
pkg/middlewares/retry/retry_test.go Updates existing tests and adds cases for proxy-not-reached vs status-based retry behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/middlewares/retry/retry.go Outdated
Comment thread pkg/middlewares/retry/retry.go
Comment thread pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Comment thread pkg/provider/kubernetes/ingress-nginx/middleware.go
Comment thread pkg/middlewares/retry/retry.go

@gndz07 gndz07 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Comment on lines +454 to +458
if maxRequestBodyBytes == 0 {
// Zero value means no limit with ingress-nginx.
// With the retry middleware, the equivalent configuration is a negative value.
maxRequestBodyBytes = -1
}
@kevinpollet kevinpollet self-assigned this Jun 19, 2026
@traefiker
traefiker merged commit 678083e into traefik:v3.7 Jun 22, 2026
51 checks passed
JuliusFreudenberger pushed a commit to JuliusFreudenberger/nix-config that referenced this pull request Jul 2, 2026
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [traefik](https://github.com/containous/traefik) | patch | `v3.7.5` → `v3.7.6` |

---

> ⚠️ **Warning**
>
> Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/12) for more information.

---

### Release Notes

<details>
<summary>containous/traefik (traefik)</summary>

### [`v3.7.6`](https://github.com/containous/traefik/blob/HEAD/CHANGELOG.md#v376-2026-06-30)

[Compare Source](traefik/traefik@v3.7.6...v3.7.6)

[All Commits](traefik/traefik@v3.7.5...v3.7.6)

**Bug fixes:**

- **\[acme, logs]** Bump github.com/go-acme/lego/v5 ([#&#8203;13154](traefik/traefik#13154) [@&#8203;ldez](https://github.com/ldez))
- **\[acme]** Bump github.com/go-acme/lego/v5 ([#&#8203;13359](traefik/traefik#13359) [@&#8203;juliens](https://github.com/juliens))
- **\[k8s, k8s/ingress-nginx]** Fix ingress-nginx ssl passthrough status updates ([#&#8203;13212](traefik/traefik#13212) [@&#8203;nickmnt](https://github.com/nickmnt))
- **\[k8s/gatewayapi]** Add missing Gateway API features in conformance tests ([#&#8203;13356](traefik/traefik#13356) [@&#8203;AnatoleLucet](https://github.com/AnatoleLucet))
- **\[k8s/gatewayapi]** Avoid collisions for Gateway API services names ([#&#8203;13367](traefik/traefik#13367) [@&#8203;rtribotte](https://github.com/rtribotte))
- **\[k8s/gatewayapi]** Ignore other gateways parentRefs and update route parent statuses only for managed gateways ([#&#8203;13397](traefik/traefik#13397) [@&#8203;rtribotte](https://github.com/rtribotte))
- **\[k8s/ingress-nginx]** Configure retry according to buffering configuration ([#&#8203;13039](traefik/traefik#13039) [@&#8203;rtribotte](https://github.com/rtribotte))
- **\[k8s/ingress-nginx]** Fix force-ssl-redirect routing 418 when TLS is terminated upstream ([#&#8203;13386](traefik/traefik#13386) [@&#8203;carloslima](https://github.com/carloslima))
- **\[k8s]** Detect EndpointSlice condition changes ([#&#8203;13405](traefik/traefik#13405) [@&#8203;kevinpollet](https://github.com/kevinpollet))
- **\[k8s]** Index Kubernetes EndpointSlice by service name ([#&#8203;13395](traefik/traefik#13395) [@&#8203;kevinpollet](https://github.com/kevinpollet))
- **\[k8s]** Sort endpointslices to keep backend IPs consistent across rebuilds ([#&#8203;13406](traefik/traefik#13406) [@&#8203;kevinpollet](https://github.com/kevinpollet))
- **\[kv]** Bump kvtools/redis to v1.2.1 ([#&#8203;13403](traefik/traefik#13403) [@&#8203;ldez](https://github.com/ldez))
- **\[middleware, authentication]** Fix x-forwarded-port in forward-auth ([#&#8203;13344](traefik/traefik#13344) [@&#8203;juliens](https://github.com/juliens))
- **\[middleware, k8s/gatewayapi]** Fix Gateway API redirect missing statuses ([#&#8203;13360](traefik/traefik#13360) [@&#8203;AnatoleLucet](https://github.com/AnatoleLucet))
- **\[middleware, k8s/gatewayapi]** Fix Host header not being modified by RequestHeaderModifier ([#&#8203;12805](traefik/traefik#12805) [@&#8203;mihuross](https://github.com/mihuross))
- **\[middleware, k8s/gatewayapi]** Fix request scheme derivation when Gateway API RequestRedirect omits scheme ([#&#8203;13347](traefik/traefik#13347) [@&#8203;gndz07](https://github.com/gndz07))
- **\[middleware]** Fix CORS Max-Age set to 0 by default ([#&#8203;13371](traefik/traefik#13371) [@&#8203;AnatoleLucet](https://github.com/AnatoleLucet))
- **\[middleware]** Fix CORS wildcard when allow-credentials is true ([#&#8203;13368](traefik/traefik#13368) [@&#8203;AnatoleLucet](https://github.com/AnatoleLucet))
- **\[server]** Add an option to remove request headers with underscores ([#&#8203;13262](traefik/traefik#13262) [@&#8203;youkoulayley](https://github.com/youkoulayley))
- **\[server]** Configurable max request header size ([#&#8203;13353](traefik/traefik#13353) [@&#8203;juliens](https://github.com/juliens))
- **\[tls]** Fix nondeterministic TLS certificate selection on shared SAN ([#&#8203;13348](traefik/traefik#13348) [@&#8203;rtribotte](https://github.com/rtribotte))
- **\[webui]** Bump axios to v1.18.0 ([#&#8203;13380](traefik/traefik#13380) [@&#8203;gndz07](https://github.com/gndz07))
- **\[websocket]** Fix connection upgrades when backend server is using h2c scheme ([#&#8203;12967](traefik/traefik#12967) [@&#8203;stffabi](https://github.com/stffabi))

**Documentation:**

- **\[k8s/crd]** Fix broken CRD reference links in IngressRoute page ([#&#8203;13375](traefik/traefik#13375) [@&#8203;s3onghyun](https://github.com/s3onghyun))
- **\[k8s/gatewayapi]** Remove experimental note for Gateway API/TLSRoute documentation ([#&#8203;13392](traefik/traefik#13392) [@&#8203;jnoordsij](https://github.com/jnoordsij))
- **\[k8s/ingress-nginx]** Add Kubernetes Ingress NGINX to the providers list ([#&#8203;13372](traefik/traefik#13372) [@&#8203;nmengin](https://github.com/nmengin))
- **\[k8s]** Align Helm chart documented values with chart v41 ([#&#8203;13366](traefik/traefik#13366) [@&#8203;mloiseleur](https://github.com/mloiseleur))
- **\[middleware, authentication, k8s/ingress-nginx]** Clarify intentional auth-response-headers gating and absence of stripping incoming X-Forwarded-\* headers ([#&#8203;13342](traefik/traefik#13342) [@&#8203;rtribotte](https://github.com/rtribotte))
- **\[middleware]** Clarify entryPoint middleware reference format ([#&#8203;13364](traefik/traefik#13364) [@&#8203;mloiseleur](https://github.com/mloiseleur))
- **\[security]** Add HTTP/2 header memory exhaustion security documentation ([#&#8203;13381](traefik/traefik#13381) [@&#8203;emilevauge](https://github.com/emilevauge))
- Adds documentations on maxHeaderBytes ([#&#8203;13363](traefik/traefik#13363) [@&#8203;juliens](https://github.com/juliens))
- Fix inaccuracies in reference documentation ([#&#8203;13304](traefik/traefik#13304) [@&#8203;sheddy-traefik](https://github.com/sheddy-traefik))

### [`v3.7.6`](https://github.com/containous/traefik/blob/HEAD/CHANGELOG.md#v376-2026-06-30)

[Compare Source](traefik/traefik@v3.7.5...v3.7.6)

[All Commits](traefik/traefik@v3.7.5...v3.7.6)

**Bug fixes:**

- **\[acme, logs]** Bump github.com/go-acme/lego/v5 ([#&#8203;13154](traefik/traefik#13154) [@&#8203;ldez](https://github.com/ldez))
- **\[acme]** Bump github.com/go-acme/lego/v5 ([#&#8203;13359](traefik/traefik#13359) [@&#8203;juliens](https://github.com/juliens))
- **\[k8s, k8s/ingress-nginx]** Fix ingress-nginx ssl passthrough status updates ([#&#8203;13212](traefik/traefik#13212) [@&#8203;nickmnt](https://github.com/nickmnt))
- **\[k8s/gatewayapi]** Add missing Gateway API features in conformance tests ([#&#8203;13356](traefik/traefik#13356) [@&#8203;AnatoleLucet](https://github.com/AnatoleLucet))
- **\[k8s/gatewayapi]** Avoid collisions for Gateway API services names ([#&#8203;13367](traefik/traefik#13367) [@&#8203;rtribotte](https://github.com/rtribotte))
- **\[k8s/gatewayapi]** Ignore other gateways parentRefs and update route parent statuses only for managed gateways ([#&#8203;13397](traefik/traefik#13397) [@&#8203;rtribotte](https://github.com/rtribotte))
- **\[k8s/ingress-nginx]** Configure retry according to buffering configuration ([#&#8203;13039](traefik/traefik#13039) [@&#8203;rtribotte](https://github.com/rtribotte))
- **\[k8s/ingress-nginx]** Fix force-ssl-redirect routing 418 when TLS is terminated upstream ([#&#8203;13386](traefik/traefik#13386) [@&#8203;carloslima](https://github.com/carloslima))
- **\[k8s]** Detect EndpointSlice condition changes ([#&#8203;13405](traefik/traefik#13405) [@&#8203;kevinpollet](https://github.com/kevinpollet))
- **\[k8s]** Index Kubernetes EndpointSlice by service name ([#&#8203;13395](traefik/traefik#13395) [@&#8203;kevinpollet](https://github.com/kevinpollet))
- **\[k8s]** Sort endpointslices to keep backend IPs consistent across rebuilds ([#&#8203;13406](traefik/traefik#13406) [@&#8203;kevinpollet](https://github.com/kevinpollet))
- **\[kv]** Bump kvtools/redis to v1.2.1 ([#&#8203;13403](traefik/traefik#13403) [@&#8203;ldez](https://github.com/ldez))
- **\[middleware, authentication]** Fix x-forwarded-port in forward-auth ([#&#8203;13344](traefik/traefik#13344) [@&#8203;juliens](https://github.com/juliens))
- **\[middleware, k8s/gatewayapi]** Fix Gateway API redirect missing statuses ([#&#8203;13360](traefik/traefik#13360) [@&#8203;AnatoleLucet](https://github.com/AnatoleLucet))
- **\[middleware, k8s/gatewayapi]** Fix Host header not being modified by RequestHeaderModifier ([#&#8203;12805](traefik/traefik#12805) [@&#8203;mihuross](https://github.com/mihuross))
- **\[middleware, k8s/gatewayapi]** Fix request scheme derivation when Gateway API RequestRedirect omits scheme ([#&#8203;13347](traefik/traefik#13347) [@&#8203;gndz07](https://github.com/gndz07))
- **\[middleware]** Fix CORS Max-Age set to 0 by default ([#&#8203;13371](traefik/traefik#13371) [@&#8203;AnatoleLucet](https://github.com/AnatoleLucet))
- **\[middleware]** Fix CORS wildcard when allow-credentials is true ([#&#8203;13368](traefik/traefik#13368) [@&#8203;AnatoleLucet](https://github.com/AnatoleLucet))
- **\[server]** Add an option to remove request headers with underscores ([#&#8203;13262](traefik/traefik#13262) [@&#8203;youkoulayley](https://github.com/youkoulayley))
- **\[server]** Configurable max request header size ([#&#8203;13353](traefik/traefik#13353) [@&#8203;juliens](https://github.com/juliens))
- **\[tls]** Fix nondeterministic TLS certificate selection on shared SAN ([#&#8203;13348](traefik/traefik#13348) [@&#8203;rtribotte](https://github.com/rtribotte))
- **\[webui]** Bump axios to v1.18.0 ([#&#8203;13380](traefik/traefik#13380) [@&#8203;gndz07](https://github.com/gndz07))
- **\[websocket]** Fix connection upgrades when backend server is using h2c scheme ([#&#8203;12967](traefik/traefik#12967) [@&#8203;stffabi](https://github.com/stffabi))

**Documentation:**

- **\[k8s/crd]** Fix broken CRD reference links in IngressRoute page ([#&#8203;13375](traefik/traefik#13375) [@&#8203;s3onghyun](https://github.com/s3onghyun))
- **\[k8s/gatewayapi]** Remove experimental note for Gateway API/TLSRoute documentation ([#&#8203;13392](traefik/traefik#13392) [@&#8203;jnoordsij](https://github.com/jnoordsij))
- **\[k8s/ingress-nginx]** Add Kubernetes Ingress NGINX to the providers list ([#&#8203;13372](traefik/traefik#13372) [@&#8203;nmengin](https://github.com/nmengin))
- **\[k8s]** Align Helm chart documented values with chart v41 ([#&#8203;13366](traefik/traefik#13366) [@&#8203;mloiseleur](https://github.com/mloiseleur))
- **\[middleware, authentication, k8s/ingress-nginx]** Clarify intentional auth-response-headers gating and absence of stripping incoming X-Forwarded-\* headers ([#&#8203;13342](traefik/traefik#13342) [@&#8203;rtribotte](https://github.com/rtribotte))
- **\[middleware]** Clarify entryPoint middleware reference format ([#&#8203;13364](traefik/traefik#13364) [@&#8203;mloiseleur](https://github.com/mloiseleur))
- **\[security]** Add HTTP/2 header memory exhaustion security documentation ([#&#8203;13381](traefik/traefik#13381) [@&#8203;emilevauge](https://github.com/emilevauge))
- Adds documentations on maxHeaderBytes ([#&#8203;13363](traefik/traefik#13363) [@&#8203;juliens](https://github.com/juliens))
- Fix inaccuracies in reference documentation ([#&#8203;13304](traefik/traefik#13304) [@&#8203;sheddy-traefik](https://github.com/sheddy-traefik))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNTAuMSIsInVwZGF0ZWRJblZlciI6IjQzLjE1MC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://git.jfreudenberger.de/JuliusFreudenberger/nix-config/pulls/16
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants