Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request (Error Pages): Possibility to change status code #2039

Open
MichaelErmer opened this issue Sep 1, 2017 · 10 comments
Open

Feature Request (Error Pages): Possibility to change status code #2039

MichaelErmer opened this issue Sep 1, 2017 · 10 comments
Labels
area/middleware contributor/wanted Participation from an external contributor is highly requested kind/enhancement a new or improved feature. priority/P3 maybe

Comments

@MichaelErmer
Copy link
Contributor

MichaelErmer commented Sep 1, 2017 •
edited
Loading

Do you want to request a feature or report a bug?

feature

Problem

We are serving millions of tracking scripts every day, we have to make sure that in case of any upstream errors/downtimes the scripts still get served with status code 200 and "valid javascript", so our clients sites are not affected.

With nxing it is possible to intercept upstream errors and rewrite them to another status code:

  error_page 501 502 503 =200 /200.html;
  location = /200.html {
    keepalive_timeout 0;
    internal;
    root /var/www;
  }

This results in the request being served with status OK and an empty file containing //e so errors can be monitored.
@n1ru4l
Copy link

n1ru4l commented Apr 16, 2020

Not sure if this fits the use-case:

I want to have IPWhitelisting for some services. In case someone from outside tries to access those services he should receive a 404 Error Code instead of 403.

@jbdoumenjou jbdoumenjou mentioned this issue Jul 27, 2020
Closed
@er1z
Copy link

er1z commented Aug 24, 2020

Any update on this issue? I really don't want to reveal that a service is available under particular (sub)domain; configuring IpWhitelist to return 404 instead of 403 would be great.

@kvncrw
Copy link
Contributor

kvncrw commented Aug 25, 2020 •
edited
Loading

Greetings @er1z -- issues that are tagged priority/P3 indicate that the feature would likely need to be proposed and then implemented by a member of the community (P3 items are typically not prioritized on our internal development roadmap). We are open to PRs and proposals, alternatively, this functionality could be implemented using the custom middleware plugin system.

https://docs.traefik.io/contributing/maintainers/#issues-priority

@er1z
Copy link

er1z commented Aug 25, 2020

Unfortunately I'm not into the Golang but if I experiment with adding such a feature can I expect that you'll review my CR with hints what to improve?

@RafPe
Copy link

RafPe commented Oct 22, 2020 •
edited
Loading

@michael-k Worked on this one with @Lepkem during the hackathon. Please check if the new plugin would do the work for you https://github.com/Lepkem/traefik-plugin-response-code-override

@jspdown jspdown mentioned this issue Feb 12, 2021
Closed
@linuxgemini
Copy link

This feature request helps handling (near) inputless oauth authentication as this will help the authentication handler to not have Traefik specific quirks.

@RafPe
Copy link

RafPe commented Feb 12, 2021

@linuxgemini did you check out the plugin I mentioned ? It's already available :)

@linuxgemini
Copy link

@RafPe I'd rather have this functionality within Traefik itself, rather than a plugin.

@RafPe
Copy link

RafPe commented Feb 12, 2021

@linuxgemini I get that. The plugin arise as way of addressing this feature request in the most recent hackathons.

Looking from perspective of solutions I'm pretty sure it would make ur life easier :) even in the time u wait for implementation of this feature

@atze234 atze234 mentioned this issue Sep 21, 2021
Closed
jfly added a commit to jfly/traefik that referenced this issue Sep 17, 2023
@jfly
Add rejectStatusCode option to IPAllowList middleware
bfb94fe 
If not specified, this defaults to the old behavior (returning a HTTP
403 Forbidden).

Sometimes it's preferable to return a 404 rather than a 403 when
rejecting a request. For example, you may not want to leak the fact that
a page even exists.

I see some other people have asked for this. See:
- https://www.reddit.com/r/Traefik/comments/xkcxhb/hide_forbidden_pages_from_public_view/
- traefik#2039: It's not clear to me
  if the OP was requesting something specific to the `IPAllowList` or
  not, but there are definitely some people asking for this in the
  thread.
@jfly jfly mentioned this issue Sep 17, 2023
Merged
2 tasks
jfly added a commit to jfly/traefik that referenced this issue Sep 17, 2023
@jfly
Add rejectStatusCode option to IPAllowList middleware
eca58f3 
If not specified, this defaults to the old behavior (returning a HTTP
403 Forbidden).

Sometimes it's preferable to return a 404 rather than a 403 when
rejecting a request. For example, you may not want to leak the fact that
a page even exists.

I see some other people have asked for this. See:
- https://www.reddit.com/r/Traefik/comments/xkcxhb/hide_forbidden_pages_from_public_view/
- traefik#2039: It's not clear to me
  if the OP was requesting something specific to the `IPAllowList` or
  not, but there are definitely some people asking for this in the
  thread.
jfly added a commit to jfly/traefik that referenced this issue Nov 27, 2023
@jfly
Add rejectStatusCode option to IPAllowList middleware
40bf015 
If not specified, this defaults to the old behavior (returning a HTTP
403 Forbidden).

Sometimes it's preferable to return a 404 rather than a 403 when
rejecting a request. For example, you may not want to leak the fact that
a page even exists.

I see some other people have asked for this. See:
- https://www.reddit.com/r/Traefik/comments/xkcxhb/hide_forbidden_pages_from_public_view/
- traefik#2039: It's not clear to me
  if the OP was requesting something specific to the `IPAllowList` or
  not, but there are definitely some people asking for this in the
  thread.
jfly added a commit to jfly/traefik that referenced this issue Dec 15, 2023
@jfly
Add rejectStatusCode option to IPAllowList middleware
51bdc41 
If not specified, this defaults to the old behavior (returning a HTTP
403 Forbidden).

Sometimes it's preferable to return a 404 rather than a 403 when
rejecting a request. For example, you may not want to leak the fact that
a page even exists.

I see some other people have asked for this. See:
- https://www.reddit.com/r/Traefik/comments/xkcxhb/hide_forbidden_pages_from_public_view/
- traefik#2039: It's not clear to me
  if the OP was requesting something specific to the `IPAllowList` or
  not, but there are definitely some people asking for this in the
  thread.
jfly added a commit to jfly/traefik that referenced this issue Dec 15, 2023
@jfly
Add rejectStatusCode option to IPAllowList middleware
b91a0a2 
If not specified, this defaults to the old behavior (returning a HTTP
403 Forbidden).

Sometimes it's preferable to return a 404 rather than a 403 when
rejecting a request. For example, you may not want to leak the fact that
a page even exists.

I see some other people have asked for this. See:
- https://www.reddit.com/r/Traefik/comments/xkcxhb/hide_forbidden_pages_from_public_view/
- traefik#2039: It's not clear to me
  if the OP was requesting something specific to the `IPAllowList` or
  not, but there are definitely some people asking for this in the
  thread.
jfly added a commit to jfly/traefik that referenced this issue Dec 15, 2023
@jfly
Add rejectStatusCode option to IPAllowList middleware
f198c97 
If not specified, this defaults to the old behavior (returning a HTTP
403 Forbidden).

Sometimes it's preferable to return a 404 rather than a 403 when
rejecting a request. For example, you may not want to leak the fact that
a page even exists.

I see some other people have asked for this. See:
- https://www.reddit.com/r/Traefik/comments/xkcxhb/hide_forbidden_pages_from_public_view/
- traefik#2039: It's not clear to me
  if the OP was requesting something specific to the `IPAllowList` or
  not, but there are definitely some people asking for this in the
  thread.
@rtribotte rtribotte mentioned this issue Dec 27, 2023
Closed
2 tasks
mmatur pushed a commit to jfly/traefik that referenced this issue Jan 9, 2024
@jfly @mmatur
Add rejectStatusCode option to IPAllowList middleware
3847a84 
If not specified, this defaults to the old behavior (returning a HTTP
403 Forbidden).

Sometimes it's preferable to return a 404 rather than a 403 when
rejecting a request. For example, you may not want to leak the fact that
a page even exists.

I see some other people have asked for this. See:
- https://www.reddit.com/r/Traefik/comments/xkcxhb/hide_forbidden_pages_from_public_view/
- traefik#2039: It's not clear to me
  if the OP was requesting something specific to the `IPAllowList` or
  not, but there are definitely some people asking for this in the
  thread.
@mildronize mildronize mentioned this issue Feb 2, 2024
Open
@kevinpollet kevinpollet mentioned this issue May 16, 2024
Closed
2 tasks
@kevinpollet kevinpollet mentioned this issue May 23, 2024
Closed
2 tasks
@col-panic col-panic mentioned this issue Jun 3, 2024
Closed
@nmengin nmengin added the contributor/wanted Participation from an external contributor is highly requested label Jul 1, 2024
@sevensolutions
Copy link
Contributor

sevensolutions commented Feb 7, 2025 •
edited
Loading

Hi there!
I want to give this a try and implement it. I looked into the code a bit and i think it should be pretty easy.

My idea is to add a mapping to the configuration:

middlewares:
  test-errors:
    errors:
      status:
        - "500"
        - "501"
        - "503"
        - "505-599"
        - "418"
      service: noop@internal
      query: "/{status}.html"
      overrideStatusCodes:
        '418': 404
        '400-402': 401

The overrideStatusCodes is a mapping which means, when the error service returns a 418, we return a 404 instead and if it returns a 400, 401 or 402, we return a 401 and so on.

The configuration name overrideStatusCodes isn't really set in stone either..

What do you think?

sevensolutions added a commit to sevensolutions/traefik that referenced this issue Feb 8, 2025
@sevensolutions
feat: add support for status code rewrites in error pages middleware. t…
6ebf965 
…raefik#2039
@sevensolutions sevensolutions mentioned this issue Feb 8, 2025
Merged
2 tasks
sevensolutions added a commit to sevensolutions/traefik that referenced this issue Feb 21, 2025
@sevensolutions
Merge branch 'master' into feature/traefik#2039
b4f180e
rtribotte pushed a commit to sevensolutions/traefik that referenced this issue Mar 3, 2025
@sevensolutions @rtribotte
feat: add support for status code rewrites in error pages middleware. t…
83d7a0f 
…raefik#2039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/middleware contributor/wanted Participation from an external contributor is highly requested kind/enhancement a new or improved feature. priority/P3 maybe
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@MichaelErmer @er1z @kvncrw @linuxgemini @ldez @nmengin @RafPe @n1ru4l @sevensolutions