Fix messenger middleware merge#63
Merged
jstojiljkovic merged 3 commits intoJul 12, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jstojiljkovic
added a commit
that referenced
this pull request
Jul 12, 2026
jstojiljkovic
added a commit
that referenced
this pull request
Jul 14, 2026
* fix: span-loss, metrics correctness, semconv alignment * fix: reconcile with messenger middleware compiler pass (#63) * chore: return cache passing tag * docs: updated changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, everyone! I noticed, that when an application adds its own middleware to a Symfony Messenger bus, OpenTelemetry middleware from the bundle is no longer registered. For example, this configuration removes OpenTelemetry middleware from the resulting middleware stack:
The problem is that Symfony does not deep merge the middleware option. Right now the bundle prepends its middleware through FrameworkBundle configuration, but application configuration replaces the prepended middleware list.
I propose moving OpenTelemetry middleware registration to a compiler pass. The compiler pass will update the middleware stack after FrameworkBundle has normalized Messenger configuration, but before Symfony builds the buses.
With this change application middleware will be preserved, tracing and metrics middleware will be added before
send_messageandhandle_message, and the configureddefault_buswill still be respected. Manually configured OpenTelemetry middleware will also not be added twice.