fix: cache:pool:prune fatals on a traced cache pool#57
Merged
jstojiljkovic merged 3 commits intoJun 26, 2026
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
Thanks, @pflueg, excellent fix. |
Contributor
Author
|
Thanks alot - especially for your work @jstojiljkovic ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cache:pool:prunefails with a fatal error when cache tracing is enabled (the default) and a prunable pool is configured - typically a DB-backed app cache. Since the command is usually run on a schedule, it surfaces as a recurring failure of the cleanup job rather than an interactive error.The cause: Symfony tags prunable pools, and when a pool is wrapped for tracing, that tag is transferred onto
TraceableCachePool. Symfony's pruner then selects the decorator and callsprune()on it - a method the decorator did not implement, resulting inCall to undefined method ...TraceableCachePool::prune().The fix follows Symfony's own
TraceableAdapter:TraceableCachePoolnow implementsPruneableInterfaceand delegatesprune()to the wrapped pool, returningfalsewhen that pool is not prunable. The tag-aware and namespaced variants inherit the behaviour.Two tests cover it - delegation to a prunable pool, and
falsefor a non-prunable one. Full suite passes, PHPStan level 10 clean.Fixes #56.