fix: re-key stream chunks for AsyncResponse compatibility#35
Merged
Conversation
srekcud
added a commit
to srekcud/opentelemetry-symfony-bundle
that referenced
this pull request
May 10, 2026
Without the SplObjectStorage map, chunks yielded by the inner client are keyed on the bare response, so RetryableHttpClient (or any decorator above this one) cannot look up the wrapper it handed in and Symfony's AsyncResponse throws "UnexpectedValueException: Object not found". Mirrors the fix applied to TraceableHttpClient in tracewayapp#35.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TraceableHttpClient::stream() not re-keying chunks back to TracedResponse wrappers, which caused UnexpectedValueException when used with RetryableHttpClient or any decorator using AsyncResponse internally.
Closes #34