fix: register OtelLogHandler in prepend() to fix bundle loading order#18
Merged
jstojiljkovic merged 3 commits intoApr 16, 2026
Merged
Conversation
Move OtelLogHandler and OtelLoggerFlushSubscriber service definitions from load() to prepend(), right after the monolog handler config is prepended. This ensures the services exist before MonologBundle::load() compiles its handler references, regardless of bundle registration order in bundles.php.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
Hi @srekcud, |
Contributor
Author
|
Yep i will check that in the evening :) |
Verify that the container compiles successfully when MonologBundle is registered before OpenTelemetryBundle with log_export_enabled: true. Add symfony/monolog-bundle to require-dev to support this test.
Contributor
Author
|
Test added @jstojiljkovic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move OtelLogHandler and OtelLoggerFlushSubscriber service definitions from load() to prepend(), right after the monolog handler config is prepended.
This ensures the services exist before MonologBundle::load() compiles its handler references, regardless of bundle registration order in bundles.php.
Fixes #17