Skip to content

Instead of conflicts with doctrine < 4 - disallow doctrine tracing for now? #8

Description

@AndreasA

Hi instead of not allowing to install the bundle at all with doctrine < 3.x, it would be better (for now) to disallow doctrine tracing using corresponding Symfony config validators.

That way everything else can be used at least.

And e.g. using the doctrine auto instrumetnation seeems to work mostly with doctrine dbal 3.x at least but Symfony root spans etc. would still be necessary.

e.g. using normalization, ifTrue with validate and defaultValue config options.

See https://symfony.com/doc/current/components/config/definition.html#validation-rules
and e.g. messenger part in symfony framework config
https://github.com/symfony/symfony/blob/8.1/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L1656

@jstojiljkovic i can also create a PR for this, if there is interest.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions