fix(cli): label reasoning vs toolcall slot explicitly in /model set output (#1182)

Davidson3556 · Davidson3556 · commit 8ec5892620fe · 2026-05-02T11:58:24.000-07:00
Reviewer (#1192) ran `/model set anthropic claude-haiku-4-5-20251001` and asked "how is the reasoning model changing then?" because the success line read switched LLM provider: anthropic (claude-haiku-4-5-20251001) with no indication of which slot the parenthetical model went into. The /model show table below it then showed reasoning and toolcall both equal to that model (toolcall was already haiku, reasoning had just changed), which made it look like one command had silently overwritten both. It hadn't — the parser treats the second positional as the reasoning model and the toolcall row was unchanged — but the message made the right behavior look wrong. Always label both slots on a switch: switched LLM provider: anthropic reasoning model: claude-haiku-4-5-20251001 (ANTHROPIC_REASONING_MODEL) [toolcall model: ... (ANTHROPIC_TOOLCALL_MODEL)] # only when --toolcall-model was passed
diff --git a/app/cli/interactive_shell/commands.py b/app/cli/interactive_shell/commands.py
@@ -231,9 +231,15 @@ def switch_llm_provider(
     env_path = sync_env_values(values)
     os.environ.update(values)
 
+    # Be explicit about which slot each model lands in. The previous output
+    # ("switched LLM provider: anthropic (X)") read ambiguously: a reviewer
+    # ran `/model set anthropic claude-haiku-...` and asked "how is the
+    # reasoning model changing then?" because `(X)` did not say *which*
+    # slot X went into. Always label both slots on a switch.
+    console.print(f"[green]switched LLM provider:[/green] {provider.value}")
     console.print(
-        f"[green]switched LLM provider:[/green] {provider.value} "
-        f"[dim]({selected_model or 'provider default'})[/dim]"
+        f"[green]reasoning model:[/green] {selected_model or 'provider default'} "
+        f"[dim]({provider.model_env})[/dim]"
     )
     if selected_toolcall:
         console.print(
diff --git a/tests/cli/interactive_shell/test_commands.py b/tests/cli/interactive_shell/test_commands.py
@@ -406,6 +406,11 @@ def test_set_switches_provider(
         output = buf.getvalue()
         assert "switched LLM provider" in output
         assert "anthropic" in output
+        # Reviewer (#1192) couldn't tell from "anthropic (X)" which slot the
+        # model went into; the success message must now explicitly label the
+        # reasoning slot and name the env var it lands in.
+        assert "reasoning model:" in output
+        assert "ANTHROPIC_REASONING_MODEL" in output
         assert "LLM_PROVIDER=anthropic" in (tmp_path / ".env").read_text(encoding="utf-8")
 
     def test_set_refuses_when_credential_missing(
