fix: move stdlib json import to module level in hot-path functions

cloudenochcsis · cloudenochcsis · commit 85cc283e9aff · 2026-05-03T16:40:37.000+02:00
Hoists `import json` from inside hot-path function bodies to module top in two services, matching the pattern from #1216 (which fixed #1209 for `copy` and `datetime` in app/nodes/). - app/services/tracer_client/tracer_integrations.py - get_all_integrations: import was inside a `for` loop iterating integration records, re-running the import statement once per iteration - get_grafana_credentials: import was per-call during integration resolution - app/services/lambda_client.py - invoke_function: import was per Lambda invocation Fixes #1242
diff --git a/app/services/lambda_client.py b/app/services/lambda_client.py
@@ -1,6 +1,7 @@
 """Lambda client for function inspection and log retrieval."""
 
 import base64
+import json
 from contextlib import suppress
 from io import BytesIO
 from typing import Any
@@ -325,8 +326,6 @@ def invoke_function(
     if credentials_error:
         return credentials_error
 
-    import json
-
     try:
         kwargs = {
             "FunctionName": function_name,
diff --git a/app/services/tracer_client/tracer_integrations.py b/app/services/tracer_client/tracer_integrations.py
@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import json
 import logging
 from dataclasses import dataclass
 from typing import Any
@@ -65,8 +66,6 @@ def get_all_integrations(self) -> list[dict[str, Any]]:
         for integration in integrations:
             creds = integration.get("credentials", {})
             if isinstance(creds, str):
-                import json
-
                 try:
                     integration["credentials"] = json.loads(creds)
                 except (json.JSONDecodeError, TypeError):
@@ -98,8 +97,6 @@ def get_grafana_credentials(self) -> GrafanaIntegrationCredentials:
 
         credentials = integration.get("credentials", {})
         if isinstance(credentials, str):
-            import json
-
             try:
                 credentials = json.loads(credentials)
             except (json.JSONDecodeError, TypeError):
