Repository navigation
fix(store): preserve extensionless burnpack paths - #5494
Merged
Merged
Conversation
rioyu123
force-pushed
the
codex/fix-burnpack-exact-path
branch
from
August 26, 2026 16:58
1d7ef24 to
09a0dd0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes extensionless Burnpack paths by applying extension policy exactly once across store and pack APIs.
Changes:
- Adds exact-path reader and configurable writer extension behavior.
- Aligns
BurnpackStoresave, load, and overwrite paths. - Adds regression coverage for direct, atomic, and store operations.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
crates/burn-store/tests/burnpack_store.rs |
Tests extensionless store behavior. |
crates/burn-store/src/burnpack.rs |
Applies store path policy once. |
crates/burn-pack/tests/round_trip.rs |
Tests exact direct writes and reads. |
crates/burn-pack/tests/lazy_writer.rs |
Tests exact atomic writes. |
crates/burn-pack/src/writer.rs |
Adds configurable auto-extension. |
crates/burn-pack/src/reader.rs |
Adds exact-path loading. |
crates/burn-pack/src/lib.rs |
Documents the new file API. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5494 +/- ##
==========================================
+ Coverage 67.68% 67.72% +0.04%
==========================================
Files 1257 1257
Lines 194831 194919 +88
==========================================
+ Hits 131863 132012 +149
+ Misses 62968 62907 -61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo run-checkshas been executed.Related Issues/PRs
Fixes #5482.
Changes
BurnpackStoreresolved its configured path first, butburn-packapplied its own extension fallback again. As a result,.auto_extension(false)still wrote tomodel.bpk, the overwrite guard checked a different path from the writer, and an exact load could fall back to the sibling.bpkfile.Writerto keep an extensionless path for both direct and atomic writes.Readerentry point so higher-level callers do not reapply fallback behavior.BurnpackStoreapply its extension policy exactly once for save, overwrite checks, and load.Testing
cargo run-checks(Rust 1.96.0)cargo test -p burn-pack -p burn-storecargo check -p burn-store --no-default-featurescargo clippy -p burn-pack -p burn-store --all-targets -- -D warningscargo fmt --all -- --check