Merged
Conversation
Replaces circe-generic-extras with circe-generic by renaming fields to snake_case. Adds a custom Arbitrary instance to work around a missing scalacheck-shapeless dependency on Scala 3.
ybasket
commented
Jul 28, 2021
| privateKey: String, | ||
| clientEmail: String, | ||
| authUri: String | ||
| project_id: String, |
Contributor
Author
There was a problem hiding this comment.
Some of them seem unused, so they could be removed. Mirroring the snake_case of the input is the easiest way to work around the missing circe-generic-extras, but it's also possible to write a Decoder by hand (the format should basically never change) or try to pre-process the JSON before decoding. Let me know if you prefer a different approach.
Contributor
There was a problem hiding this comment.
I ported these from another older library, so I don't think the extra fields are needed anymore.
I think this approach for snake case should be fine.
Member
|
Not sure if changing the model fields is ok. Seems true but let's ask @janstenpickle to be sure. |
catostrophe
approved these changes
Jul 28, 2021
# Conflicts: # modules/stackdriver-http-exporter/src/main/scala/io/janstenpickle/trace4cats/stackdriver/oauth/GoogleAccountParser.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
circe-generic-extraswith circe-generic by renaming fields to snake_case. Adds a custom Arbitrary instance to work around a missingscalacheck-shapelessdependency on Scala 3.