Improvements to Ask & Local#911
Merged
janstenpickle merged 5 commits intotrace4cats:masterfrom Oct 18, 2023
alejandrohdezma:feature/improvements
Merged
Improvements to Ask & Local#911janstenpickle merged 5 commits intotrace4cats:masterfrom alejandrohdezma:feature/improvements
Ask & Local#911janstenpickle merged 5 commits intotrace4cats:masterfrom
alejandrohdezma:feature/improvements
Conversation
| @@ -0,0 +1,15 @@ | |||
| package trace4cats.context | |||
|
|
|||
| object syntax { | |||
Collaborator
There was a problem hiding this comment.
I think it might be good to include some provide syntax here too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 How to review this PR?
This PR was created with the idea of being reviewed commit by commit. Each commit contains an incremental change that makes it easier to review. Also some of the commits contain additional information in their description to help understand why the change was made.
I also recommend checking "Hide whitespace" when reviewing this PR!
🚀 What's included in this PR?
New method
Ask.maketo ease creating a newAskinstanceAdd
Askinstances forTupletypesProvide automatic derivation of
Askinstances for tuple types if we have instances for underlying types.Provide implicit syntax for
LocalProvide
Askinstances forSpanContext,TraceId&SpanId