Merged
Conversation
added 3 commits
June 19, 2023 15:24
As cats-effect 3.4 offers more than millisecond precision, ensure to not convert to millis in between. Bumps a few dependencies on the way as Scala 3 had to be bumped anyway for new CE versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As cats-effect 3.4 offers more than millisecond precision, ensure to not convert to millis in between.
Bumps a few dependencies on the way as Scala 3 had to be bumped anyway for new CE versions.
Relates to trace4cats/trace4cats-jaeger#175 and trace4cats/trace4cats-opentelemetry#297 that ensure the gained precision is properly encoded. And to #630 that was requesting more fine-grained span timings before.