Skip to content

Module re-org#742

Merged
janstenpickle merged 14 commits intomasterfrom
module-reorg-part1
Apr 28, 2022
Merged

Module re-org#742
janstenpickle merged 14 commits intomasterfrom
module-reorg-part1

Conversation

@janstenpickle
Copy link
Copy Markdown
Collaborator

@janstenpickle janstenpickle commented Apr 26, 2022 •
edited
Loading

Part of #701, supersedes #702

I've kept package names the same for now, we can probably do that in a separate PR

@janstenpickle
Copy link
Copy Markdown
Collaborator Author

janstenpickle commented Apr 26, 2022

I think filtering can probably move to core also. WDYT @bplommer @catostrophe?

@janstenpickle
Copy link
Copy Markdown
Collaborator Author

janstenpickle commented Apr 26, 2022

I've left inject intact so that people will get dependency updates. I think if we change the package name on Trace we can leave a @deprecated version in inject.

@janstenpickle janstenpickle mentioned this pull request Apr 26, 2022
Closed
@catostrophe
Copy link
Copy Markdown
Member

catostrophe commented Apr 27, 2022

Do we have a written plan on package renaming? Currently, the new module organization looks inconsistent with packages and triggers my OCD.

catostrophe
catostrophe reviewed Apr 27, 2022
View reviewed changes
catostrophe
catostrophe reviewed Apr 27, 2022
View reviewed changes
catostrophe
catostrophe reviewed Apr 27, 2022
View reviewed changes
@janstenpickle janstenpickle mentioned this pull request Apr 27, 2022
Closed
@janstenpickle
Copy link
Copy Markdown
Collaborator Author

janstenpickle commented Apr 27, 2022

Do we have a written plan on package renaming? Currently, the new module organization looks inconsistent with packages and triggers my OCD.

No plan yet, I've created us an issue to discss #744

bplommer
bplommer reviewed Apr 27, 2022
View reviewed changes
@janstenpickle janstenpickle mentioned this pull request Apr 27, 2022
Closed
@janstenpickle
Copy link
Copy Markdown
Collaborator Author

janstenpickle commented Apr 27, 2022 •
edited
Loading

OK, I think that's everything in terms of module consolidation. Here's a summary of what's gone where:

model -> kernel
core -> kernel
exporter-common -> core
exporter-stream -> core
log-exporter -> core
inject -> core
filtering -> core
dynamic-sampling -> core
dynamic-sampling-config -> core
rate-sampling -> core & tail-sampling
base -> context-utils
base-laws -> context-utils-laws
base-io -> io
inject-io -> io

This leaves us with the following modules:

context-utils
context-utils-laws
core
core-tests
fs2
io
kernel
kernel-tests
meta
tail-sampling
testkit

@janstenpickle janstenpickle marked this pull request as ready for review April 27, 2022 12:19
@janstenpickle
Copy link
Copy Markdown
Collaborator Author

janstenpickle commented Apr 27, 2022

@bplommer @catostrophe WDYT about moving dynamic-sampling and dynamic-sampling-config into core?

@catostrophe
Copy link
Copy Markdown
Member

catostrophe commented Apr 27, 2022

@bplommer @catostrophe WDYT about moving dynamic-sampling and dynamic-sampling-config into core?

I'm fine

@janstenpickle janstenpickle merged commit f339da8 into master Apr 28, 2022
@janstenpickle janstenpickle deleted the module-reorg-part1 branch April 28, 2022 08:30
@catostrophe catostrophe added the enhancement New feature or request label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catostrophe catostrophe catostrophe approved these changes

@ybasket ybasket Awaiting requested review from ybasket

+1 more reviewer

@bplommer bplommer bplommer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janstenpickle @catostrophe @bplommer