Merged
Conversation
Adds the ability to obtain a span context from a `Trace` typeclass. This has been added as a more powerful typeclass so compatibility with Natchez can be preserved.
janstenpickle
force-pushed
the
trace-span-context
branch
from
9c1cb71 to
d590525
Compare
catostrophe
reviewed
Apr 26, 2022
| type G[x] = Kleisli[IO, Env[IO], x] | ||
| implicit val gHasLocalSpan: Local[G, Span[IO]] = Local[G, Env[IO]].focus(Env.span) | ||
| implicitly[Trace[G]] | ||
| implicitly[Trace.WithContext[G]] |
Member
There was a problem hiding this comment.
Could you also add summon tests for EitherT and EitherT ∘ Kleisli instances?
Collaborator
Author
There was a problem hiding this comment.
Ah yeah, they were missing before
| } | ||
|
|
||
| object Trace extends TraceInstancesLowPriority { | ||
| trait WithContext[F[_]] extends Trace[F] { |
Member
There was a problem hiding this comment.
I think IOLocal instance also should be enhanced?
Collaborator
Author
There was a problem hiding this comment.
Oops, forgot that PR got merged
catostrophe
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to obtain a span context from a
Tracetypeclass. This has been added as a more powerful typeclass so compatibility with Natchez can be preserved.An obivious question may be, why not just use
Askhere? Obtaining the context this way means that we don't have to either pass another type parameter forFonSpan[F]when usingAsk[G, Span[F]]or making users manually provide anAsk[G, SpanContext]instance usingzoom.