Throwable.getMessage can return null#713
Merged
catostrophe merged 2 commits intotrace4cats:masterfrom Mar 30, 2022
Merged
Conversation
Member
|
@tdbgamer does this issue cause NPE anywhere? If yes, we'll cut a patch release. If no, we'll cut a (stable) snapshot release as soon as this PR gets merged. |
Contributor
Author
|
@catostrophe Yeah it causes NPEs in the span exporter (at least the datadog one, but I'd expect the others might as well). Would probably be a good idea to do a patch release. |
catostrophe
reviewed
Mar 29, 2022
modules/meta/src/main/scala/io/janstenpickle/trace4cats/meta/MetaTraceUtil.scala
Outdated
Show resolved
Hide resolved
…etaTraceUtil.scala Co-authored-by: catostrophe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default to
toString()whengetMessage()returnsnull.