Clarify pandas and tqdm_notebook notation#474
Closed
watercrossing wants to merge 2 commits intotqdm:masterfrom
Closed
Clarify pandas and tqdm_notebook notation#474watercrossing wants to merge 2 commits intotqdm:masterfrom
watercrossing wants to merge 2 commits intotqdm:masterfrom
Conversation
In response to tqdm#473, I propose clarifying the documentation. It is not: `tqdm.pandas(tqdm_notebook)`, but `tqdm_notebook().pandas()`.
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 7 7
Lines 629 629
Branches 120 120
=======================================
Hits 626 626
Misses 1 1
Partials 2 2 |
casperdcl
added
to-review 🔍
chengs
approved these changes
Apr 4, 2018
Contributor
chengs
left a comment
chengs
left a comment
There was a problem hiding this comment.
Since it is a pandas issue, I am here. Looks good to me.
Contributor
|
@casperdcl any update? |
|
is there any way to get pandas registered with tqdm without it immediately drawing an unused bar? |
Contributor
|
I think there is not an elegant way to do it... |
Member
|
I think this PR is a bit wrong. It should be |
Contributor
|
@casperdcl eh, you're right about |
Member
|
ah mentioned in #419 (and #177 -> #192) you need from tqdm._tqdm_notebook import tqdm_notebook
tqdm_notebook.pandas(...)This will hopefully change soon to: # force notebook: from tqdm.notebook import tqdm
# or auto-detect notebook/CLI
from tqdm.autonotebook import tqdm
tqdm.pandas()Maybe I won't wait for v5 to do this. |
Member
|
closed by 97a9393 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #473, I propose clarifying the documentation.
It is not:
tqdm.pandas(tqdm_notebook),but
tqdm_notebook().pandas().