Skip to content

Ignore coverall failures#283

Merged
lrq3000 merged 1 commit intotqdm:masterfrom
pjvandehaar:master
Oct 7, 2016
Merged

Ignore coverall failures#283
lrq3000 merged 1 commit intotqdm:masterfrom
pjvandehaar:master

Conversation

@pjvandehaar
Copy link
Copy Markdown
Contributor

@pjvandehaar pjvandehaar commented Oct 7, 2016 •
edited
Loading

When running locally, I get:

$ make test
...
ERROR: InvocationError: '/Users/peter/PROJECTS/tqdm/.tox/py26/bin/coveralls'
...
ERROR:   py26: commands failed
...

$ /Users/peter/PROJECTS/tqdm/.tox/py35/bin/coveralls
You have to provide either repo_token in .coveralls.yml, or launch via Travis or CircleCI

This fixes that issue.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 7, 2016

Current coverage is 90.39% (diff: 100%)

Merging #283 into master will not change coverage

@@             master       #283   diff @@
==========================================
  Files             7          7          
  Lines           479        479          
  Methods           0          0          
  Messages          0          0          
  Branches         86         86          
==========================================
  Hits            433        433          
  Misses           44         44          
  Partials          2          2

Powered by Codecov. Last update bc9d113...48454da

1 similar comment
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 7, 2016 •
edited
Loading

Current coverage is 90.39% (diff: 100%)

Merging #283 into master will not change coverage

@@             master       #283   diff @@
==========================================
  Files             7          7          
  Lines           479        479          
  Methods           0          0          
  Messages          0          0          
  Branches         86         86          
==========================================
  Hits            433        433          
  Misses           44         44          
  Partials          2          2

Powered by Codecov. Last update bc9d113...48454da

@pjvandehaar pjvandehaar mentioned this pull request Oct 7, 2016
Closed
@lrq3000 lrq3000 added the p0-bug-critical ☢ Exception rasing label Oct 7, 2016
@lrq3000 lrq3000 merged commit 996f47d into tqdm:master Oct 7, 2016
@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Oct 7, 2016

Thank you @pjvandehaar :)

@pjvandehaar
Copy link
Copy Markdown
Contributor Author

pjvandehaar commented Oct 7, 2016

Happy to help out. :) You'll have to watch out for signs of coveralls failing silently, though.

@casperdcl
Copy link
Copy Markdown
Member

casperdcl commented Oct 18, 2016

thanks @pjvandehaar feel free to 👍 this link

@casperdcl casperdcl added p2-bug-warning ⚠ Visual output bad and removed p0-bug-critical ☢ Exception rasing labels Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

p2-bug-warning ⚠ Visual output bad

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pjvandehaar @codecov-io @lrq3000 @casperdcl