Copyediting for README#240
Conversation
Signed-off-by: Stephen L. <[email protected]>
…#239) Get rid of exception when closing tqdm_notebook without a total
Add note and link to bpython.
github/Github -> GitHub PyPi/pypi -> PyPI Licence -> License added s
Current coverage is 90.56% (diff: 100%)@@ master #240 diff @@
==========================================
Files 7 7
Lines 477 477
Methods 0 0
Messages 0 0
Branches 85 85
==========================================
Hits 432 432
Misses 44 44
Partials 1 1
|
|
Thank's, tell us when you think you're done with this PR so that we can merge in. |
|
@lrq3000 Wait a second - just spotted something. |
|
@lrq3000 should be GTG |
5 similar comments
|
@coveralls why you gotta malfunction? and why's my readme change failing Travis CI?!?! |
|
Ha, manually edited the "Propose change" button to not be disabled. seeing if Travis CI still has that problem... |
2 similar comments
|
Ah no @CrazyPython, I didn't know we could write so small in Github :) But anyway I'd like to fix that. @casperdcl , how do you force push? Do you have to disable the protection from Github interface everytime? |
|
yes, it's a different hash on my machine too. Weird. anyway maybe it's better this way if @CrazyPython is desperate to have lines attributed to him. All I need to do is leave everyrhing as is, except change the author of the last commit back to him. |
|
@lrq3000 A trick with |
|
@casperdcl it's not much, just a joke :) Lol, this has happened before... |
|
@CrazyPython Ah nice! Did you see this one? |
|
About commit authorship attribution, yeah but anyway it's better to fix that so that we know how to do in the future, and it's better practice anyway. |
|
@casperdcl how can you change the author of a commit? Remove the commit and redo it with |
|
@lrq3000 I'm gonna use that from now on whenever I want to prove a point on GitHub. You might regret this someday... |
|
Ah lol, I should think before giving stuff next time ;) |
|
@casperdcl soon tqdm shall take over the world! |
|
I'm surprised and humbled by the number of times I see tqdm listed in pretty sweet package requirements/dependencies ... |
|
MUHAHAHA!! |
|
@casperdcl Yep me too, but it's also scary because we have to make sure that our package is robust now that others are depending on it (#222) XD @CrazyPython yeah but that's a lot of work! |
|
With great power comes great irresponsibility. |
|
Ok so let's get serious a bit ;) @casperdcl would you like to fix the author of the copyediting commit or I do it? |
|
@CrazyPython Oh wow, never thought of doing that. And that's only for github hosted projects, there are more outside. |
|
Even for sample code of a book: https://github.com/trenton3983/Fluent_Python |
|
I found a hidden little GitHub feature: https://github.com/tqdm/tqdm/branches |
|
@CrazyPython Nice finding, might be useful to clean up our branches! @casperdcl Thank you for fixing authorship :) Out of curiosity, how did you do it? |
|
That is... a lot of users. First reaction: pleasant shock. Second reaction: puzzled as to why first reaction was surprised. This is still less than what we're aiming for ;) |
|
Since when was branches hidden? Next you'll tell me you've never seen the punch card, network, or contributors pages |
|
@casperdcl Oh, I've seen those - just how do you find it without entering the URL manually? |
|
Drat it. tests. Finally looked at Travis. coverage submission has been failing specifically on py34. grrr |
|
@casperdcl It's probably coveralls that's still failing. @CrazyPython reported the issue and they said they are fixing the issue. |
|
@CrazyPython Found how to show branches from interface: Code > Branches in the submenu, just at the right of "commits". That's on the new interface only, it wasn't there before. |
|
@casperdcl About the number of users, remember it's only projects hosted on github, and projects that were published. I can bet there are a lot of in-house ipython notebooks and scripts using tqdm that are not published. |
|
@casperdcl In addition to what @lrq3000 said, there are 11k projects that aren't big enough to have a requirements.txt that use tqdm. |
No description provided.