Skip to content

Copyediting for README#240

Closed
CrazyPython wants to merge 12 commits intotqdm:masterfrom
CrazyPython:patch-5
Closed

Copyediting for README#240
CrazyPython wants to merge 12 commits intotqdm:masterfrom
CrazyPython:patch-5

Conversation

@CrazyPython
Copy link
Copy Markdown
Contributor

No description provided.

@CrazyPython CrazyPython changed the title Copyediting Copyediting for README Aug 16, 2016
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 16, 2016

Coverage Status

Coverage remained the same at 90.776% when pulling 68994bb on CrazyPython:patch-5 into 2d039fd on tqdm:master.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 16, 2016

Current coverage is 90.56% (diff: 100%)

Merging #240 into master will not change coverage

@@             master       #240   diff @@
==========================================
  Files             7          7          
  Lines           477        477          
  Methods           0          0          
  Messages          0          0          
  Branches         85         85          
==========================================
  Hits            432        432          
  Misses           44         44          
  Partials          1          1          

Powered by Codecov. Last update 0346a4a...1230522

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 16, 2016

Thank's, tell us when you think you're done with this PR so that we can merge in.

@CrazyPython
Copy link
Copy Markdown
Contributor Author

@lrq3000 Wait a second - just spotted something.

@CrazyPython
Copy link
Copy Markdown
Contributor Author

@lrq3000 should be GTG

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 16, 2016

Coverage Status

Coverage remained the same at 90.776% when pulling c30bca2 on CrazyPython:patch-5 into 2d039fd on tqdm:master.

5 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 90.776% when pulling c30bca2 on CrazyPython:patch-5 into 2d039fd on tqdm:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 90.776% when pulling c30bca2 on CrazyPython:patch-5 into 2d039fd on tqdm:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 16, 2016

Coverage Status

Coverage remained the same at 90.776% when pulling c30bca2 on CrazyPython:patch-5 into 2d039fd on tqdm:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 90.776% when pulling c30bca2 on CrazyPython:patch-5 into 2d039fd on tqdm:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 90.776% when pulling c30bca2 on CrazyPython:patch-5 into 2d039fd on tqdm:master.

@CrazyPython
Copy link
Copy Markdown
Contributor Author

@coveralls why you gotta malfunction?

and why's my readme change failing Travis CI?!?!

@CrazyPython
Copy link
Copy Markdown
Contributor Author

Ha, manually edited the "Propose change" button to not be disabled. seeing if Travis CI still has that problem...

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 16, 2016

Coverage Status

Coverage remained the same at 90.776% when pulling 1230522 on CrazyPython:patch-5 into c893d90 on tqdm:master.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 90.776% when pulling 1230522 on CrazyPython:patch-5 into c893d90 on tqdm:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 90.776% when pulling 1230522 on CrazyPython:patch-5 into c893d90 on tqdm:master.

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

Ah no @CrazyPython, I didn't know we could write so small in Github :) But anyway I'd like to fix that. @casperdcl , how do you force push? Do you have to disable the protection from Github interface everytime?

@casperdcl
Copy link
Copy Markdown
Member

yes, it's a different hash on my machine too. Weird. anyway maybe it's better this way if @CrazyPython is desperate to have lines attributed to him. All I need to do is leave everyrhing as is, except change the author of the last commit back to him.

@CrazyPython
Copy link
Copy Markdown
Contributor Author

@lrq3000 A trick with <sub><sup><sub><sup>jk</sup></sub></sup></sub>.

@CrazyPython
Copy link
Copy Markdown
Contributor Author

CrazyPython commented Aug 17, 2016

@casperdcl it's not much, just a joke :)

Lol, this has happened before...

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

@CrazyPython Ah nice! Did you see this one?

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

About commit authorship attribution, yeah but anyway it's better to fix that so that we know how to do in the future, and it's better practice anyway.

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

@casperdcl how can you change the author of a commit? Remove the commit and redo it with --author="CrazyPython" or is there another command?

@CrazyPython
Copy link
Copy Markdown
Contributor Author

@lrq3000 I'm gonna use that from now on whenever I want to prove a point on GitHub. You might regret this someday...

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

Ah lol, I should think before giving stuff next time ;)

@casperdcl
Copy link
Copy Markdown
Member

@CrazyPython
Copy link
Copy Markdown
Contributor Author

@casperdcl soon tqdm shall take over the world!

@casperdcl
Copy link
Copy Markdown
Member

I'm surprised and humbled by the number of times I see tqdm listed in pretty sweet package requirements/dependencies ...

@CrazyPython
Copy link
Copy Markdown
Contributor Author

CrazyPython commented Aug 17, 2016

MUHAHAHA!!

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

@casperdcl Yep me too, but it's also scary because we have to make sure that our package is robust now that others are depending on it (#222) XD

@CrazyPython yeah but that's a lot of work!

@CrazyPython
Copy link
Copy Markdown
Contributor Author

CrazyPython commented Aug 17, 2016

With great power comes great irresponsibility.

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

Ok so let's get serious a bit ;) @casperdcl would you like to fix the author of the copyediting commit or I do it?

@CrazyPython
Copy link
Copy Markdown
Contributor Author

CrazyPython commented Aug 17, 2016

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

@CrazyPython Oh wow, never thought of doing that. And that's only for github hosted projects, there are more outside.

casperdcl pushed a commit that referenced this pull request Aug 17, 2016
@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

@CrazyPython
Copy link
Copy Markdown
Contributor Author

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

@CrazyPython Nice finding, might be useful to clean up our branches!

@casperdcl Thank you for fixing authorship :) Out of curiosity, how did you do it? commit --author="CrazyPython" ?

@casperdcl
Copy link
Copy Markdown
Member

That is... a lot of users. First reaction: pleasant shock. Second reaction: puzzled as to why first reaction was surprised. This is still less than what we're aiming for ;)

@casperdcl
Copy link
Copy Markdown
Member

Since when was branches hidden? Next you'll tell me you've never seen the punch card, network, or contributors pages

@CrazyPython
Copy link
Copy Markdown
Contributor Author

@casperdcl Oh, I've seen those - just how do you find it without entering the URL manually?

@casperdcl
Copy link
Copy Markdown
Member

Drat it. tests. Finally looked at Travis. coverage submission has been failing specifically on py34. grrr

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

@casperdcl It's probably coveralls that's still failing. @CrazyPython reported the issue and they said they are fixing the issue.

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

@CrazyPython Found how to show branches from interface: Code > Branches in the submenu, just at the right of "commits". That's on the new interface only, it wasn't there before.

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Aug 17, 2016

@casperdcl About the number of users, remember it's only projects hosted on github, and projects that were published. I can bet there are a lot of in-house ipython notebooks and scripts using tqdm that are not published.

@CrazyPython
Copy link
Copy Markdown
Contributor Author

@casperdcl In addition to what @lrq3000 said, there are 11k projects that aren't big enough to have a requirements.txt that use tqdm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants