Get rid of exception when closing tqdm_notebook without a total#239
Merged
lrq3000 merged 2 commits intotqdm:masterfrom Aug 16, 2016
aplavin:patch-1
Merged
Get rid of exception when closing tqdm_notebook without a total#239lrq3000 merged 2 commits intotqdm:masterfrom aplavin:patch-1
lrq3000 merged 2 commits intotqdm:masterfrom
aplavin:patch-1
Conversation
| # Try to detect if there was an error or KeyboardInterrupt | ||
| # in manual mode: if n < total, things probably got wrong | ||
| if self.n < self.total: | ||
| if self.total is not None and self.n < self.total: |
Member
There was a problem hiding this comment.
Thank you @aplavin !
Can you please just change the line to:
if self.total and self.n < self.total:
(except if there's a specific reason you want to check is not None)
Current coverage is 90.56% (diff: 100%)@@ master #239 diff @@
==========================================
Files 7 7
Lines 477 477
Methods 0 0
Messages 0 0
Branches 85 85
==========================================
Hits 432 432
Misses 44 44
Partials 1 1
|
Member
|
Perfect, thank's a lot ! 👍 |
casperdcl
pushed a commit
that referenced
this pull request
Aug 16, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.