Skip to content

IPython aliased imports fix#190

Merged
casperdcl merged 1 commit intomasterfrom
ipyimports
Jul 18, 2016
Merged

IPython aliased imports fix#190
casperdcl merged 1 commit intomasterfrom
ipyimports

Conversation

@casperdcl
Copy link
Copy Markdown
Member

attempt to fix aliased imports as per #187

@casperdcl
Copy link
Copy Markdown
Member Author

@QuLogic does this fix your issue?

@codecov-io
Copy link
Copy Markdown

Current coverage is 81.40%

Merging #190 into master will not change coverage

@@             master       #190   diff @@
==========================================
  Files             8          8          
  Lines           527        527          
  Methods           0          0          
  Messages          0          0          
  Branches         99         99          
==========================================
  Hits            429        429          
  Misses           98         98          
  Partials          0          0          

Powered by Codecov. Last updated by bb53160...e53dcac

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 30, 2016

Coverage Status

Coverage remained the same at 81.404% when pulling e53dcac on ipyimports into bb53160 on master.

3 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 81.404% when pulling e53dcac on ipyimports into bb53160 on master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 81.404% when pulling e53dcac on ipyimports into bb53160 on master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 81.404% when pulling e53dcac on ipyimports into bb53160 on master.

@QuLogic
Copy link
Copy Markdown

QuLogic commented Jul 2, 2016

Yep, seems to work fine. Would be nice if the FutureWarning was caught too.

@casperdcl casperdcl merged commit ce2eace into master Jul 18, 2016
@casperdcl casperdcl deleted the ipyimports branch July 18, 2016 08:38
@casperdcl
Copy link
Copy Markdown
Member Author

can you post the FutureWarning output? don't know if that's the sort of thing we should be suppressing.

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Jul 18, 2016

On IPython 4 there is no futurewarning. What version of IPython are you running @QuLogic please?

/EDIT: sorry it was written in the title of the issue #187. So it was IPython 3. I'm not sure we can do something about it, IIRC, IPython 3 started to output these messages whenever you used ipywidgets because it was in the process of being separated into its own library.

@QuLogic
Copy link
Copy Markdown

QuLogic commented Jul 21, 2016

Yes, that's right it's IPython 3 with the warning :0: FutureWarning: IPython widgets are experimental and may change in the future. I understand the reasoning behind the warning, but I'm not directly using a widget and it seems like the tqdm team is on top of the backwards/forwards-compatibility issues so that the warning is kind of superfluous.

@lrq3000
Copy link
Copy Markdown
Member

lrq3000 commented Jul 21, 2016

Ah yes so in this case I'm not sure we can or should do anything about it. First because I'm not sure how IPython issues the warnings (normally they should be suppressed by default for the end users, except if you change filters. But if they don't use the warnings core lib, then it may not be possible to catch this), and secondly because it's considered non pythonic for a lib to catch warnings, they should be managed by the end user.

Anyway this does not hamper the functioning of tqdm, and the latest versions of IPython suppressed these warnings. Ah, the joy of managing cascaded deprecation warnings... See also the discussion at #192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants