Skip to content

RF: delay imports of ipython until necessary through adapter functions#177

Closed
yarikoptic wants to merge 1 commit intotqdm:masterfrom
yarikoptic:enh-delayed-imports
Closed

RF: delay imports of ipython until necessary through adapter functions#177
yarikoptic wants to merge 1 commit intotqdm:masterfrom
yarikoptic:enh-delayed-imports

Conversation

@yarikoptic
Copy link
Copy Markdown
Contributor

@yarikoptic yarikoptic commented Jun 2, 2016

Partially addresses #176
More of a proof of concept: compare

$> /usr/bin/time python -c 'import tqdm' 
0.15user 0.02system 0:00.18elapsed 94%CPU (0avgtext+0avgdata 30772maxresident)k

$> git co enh-delayed-imports           
Previous HEAD position was af1d7c5... readme updates, removed broken pypi download count
Switched to branch 'enh-delayed-imports'
Your branch is up-to-date with 'gh-yarikoptic/enh-delayed-imports'.

$> /usr/bin/time python -c 'import tqdm'
0.01user 0.00system 0:00.02elapsed 72%CPU (0avgtext+0avgdata 7684maxresident)k

@yarikoptic yarikoptic mentioned this pull request Jun 2, 2016
Open
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 2, 2016

Current coverage is 97.78%

Merging #177 into master will decrease coverage by 2.21%

  1. File ...dm/_tqdm_notebook.py (not in diff) was modified. more
    • Misses +6
    • Partials 0
    • Hits -6
@@             master       #177   diff @@
==========================================
  Files             8          8          
  Lines           447        451     +4   
  Methods           0          0          
  Messages          0          0          
  Branches         80         80          
==========================================
- Hits            447        441     -6   
- Misses            0         10    +10   
  Partials          0          0

Powered by Codecov. Last updated by af1d7c5...c49021d

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 2, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.2%) to 97.783% when pulling c49021d on yarikoptic:enh-delayed-imports into af1d7c5 on tqdm:master.

@casperdcl casperdcl mentioned this pull request Jun 2, 2016
Merged
@yarikoptic
Copy link
Copy Markdown
Contributor Author

yarikoptic commented Jun 2, 2016

absorbed into #179

@yarikoptic yarikoptic closed this Jun 2, 2016
@casperdcl casperdcl mentioned this pull request Jun 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yarikoptic @codecov-io @coveralls