Fix SchemaStore workflow creating empty PRs#3848
Merged
gaborbernat merged 1 commit intotox-dev:mainfrom Mar 3, 2026
Merged
Conversation
Compare parsed JSON content instead of using git diff on file text. The json.dump formatting differs from SchemaStore's prettier formatting, causing false-positive diffs on every release even when the schema content is identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
update-schemastore.yamlworkflow usedgit diff --cachedto detect schema changes, butjson.dumpformatting differs from SchemaStore's prettier formatting. This caused every release to open a PR with formatting-only diffs and no actual schema content changes (e.g. #5434).Replace file-level diff with parsed JSON comparison — only writes the file and proceeds when the schema content actually differs.