🐛 fix(exec): pass stdin through to executed command#3842
Merged
gaborbernat merged 1 commit intotox-dev:mainfrom Mar 1, 2026
Merged
🐛 fix(exec): pass stdin through to executed command#3842gaborbernat merged 1 commit intotox-dev:mainfrom
gaborbernat merged 1 commit intotox-dev:mainfrom
Conversation
`tox exec` discarded piped stdin because `StdinSource.user_only()` returns OFF when stdin is not a tty. When `no_capture` is enabled (always the case for `tox exec`), use `StdinSource.USER` directly so the subprocess inherits the parent's stdin. Fixes tox-dev#3841
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running commands via
tox execwith piped stdin silently discards the input data. For example,echo "foo" | tox exec -- python -c 'import sys; print(sys.stdin.read())'produces an empty output instead of printingfoo. This happens becauseStdinSource.user_only()returnsOFFwhensys.stdin.isatty()isFalse, mapping toDEVNULLin the subprocessPopencall.When
no_captureis enabled (whichtox execalways sets), the subprocess should inherit the parent's stdin directly viaStdinSource.USERrather than going through the tty check. This preserves the existing behavior fortox runwhile allowingtox execto work naturally with pipes and redirections.Fixes #3841