Document running tox within a Docker container by 31z4 · Pull Request #2923 · tox-dev/tox

31z4 · 2023-02-10T05:18:17Z

Created this PR to continue work on #1035. The idea is to mention 31z4/tox Docker image in the docs to gather more feedback from users. What do you guys think? Is it OK to refer to the current version of the image? Or moving the image under the tox-dev organisation or making it official would be a blocker?

Thanks for contribution

Please, make sure you address all the checklists (for details on how see
development documentation)!

ran the linter to address style issues (tox -e fix)
wrote descriptive pull request text
ensured there are test(s) validating the fix
added news fragment in docs/changelog folder
updated/extended the documentation

for more information, see https://pre-commit.ci

gaborbernat · 2023-02-10T05:55:06Z

docs/faq.rst

+
+.. code-block:: Dockerfile
+
+    FROM 31z4/tox


Could we create a tox-dev or tox org instead to host under? You can be one of it's owner's 😊

Yes I think it makes sense. Although, if we aim to make the image "official" maybe it's better to work towards this right now. This way we can save some maintenance efforts. Because we don't have to deprecate tox-dev/tox in favour of official tox. And also users don't have to migrate from the deprecated image to the official one.

Some benefits of an official image that I'd like to highlight:

Automated multi-arch builds.

Automated periodic re-builds when a base image is updated.

Better structured docs and build artefacts (e.g.. https://github.com/docker-library/repo-info/tree/master/repos/zookeeper).

Yeah let's make it so. What do you need from me to get there?

I guess nothing at this point. I'll make some usability changes to the image to conform with https://github.com/docker-library/official-images#consistency. And then will work on PRs to https://github.com/docker-library/official-images and https://github.com/docker-library/docs.

gaborbernat · 2023-02-10T05:55:51Z

docs/faq.rst

+
+.. code-block:: shell
+
+    docker run -v `pwd`:/home/tox/tests -it --rm 31z4/tox run-parallel -e black,py311


Would prefer to mount the project under the /w folder, personal preference 😅

That's possible too ☺️ But you have to specify the workdir in that case (-w /w):

docker run -v `pwd`:/w -w /w -it --rm 31z4/tox run-parallel -e black,py311

I can change image workdir from /home/tox/tests to something more concise, like /tests maybe. I agree that /home/tox/tests might be too long to type 😅

I'd make/w the default, concise better 😅

@31z4 ping on this?

I've been pretty busy recently. Hopefully will get a chance to work on the official image later this month. In the meantime https://github.com/31z4/tox-docker should be good enough for production already.

Document running tox within a Docker container

0f7fe1d

31z4 requested a review from gaborbernat as a code owner February 10, 2023 05:18

psf-chronographer bot added the bot:chronographer:provided label Feb 10, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

bac90ca

for more information, see https://pre-commit.ci

gaborbernat reviewed Feb 10, 2023

View reviewed changes

31z4 marked this pull request as draft February 14, 2023 05:45

31z4 mentioned this pull request Mar 24, 2023

Add tox docker-library/official-images#14328

Closed

10 tasks

gaborbernat marked this pull request as ready for review March 30, 2023 14:02

gaborbernat merged commit affd839 into tox-dev:main Mar 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Document running tox within a Docker container#2923

Document running tox within a Docker container#2923
gaborbernat merged 2 commits intotox-dev:mainfrom
31z4:docker-docs

31z4 commented Feb 10, 2023

Uh oh!

gaborbernat Feb 10, 2023

Uh oh!

31z4 Feb 10, 2023

Uh oh!

gaborbernat Feb 10, 2023

Uh oh!

31z4 Feb 13, 2023

Uh oh!

gaborbernat Feb 10, 2023

Uh oh!

31z4 Feb 10, 2023

Uh oh!

gaborbernat Feb 10, 2023

Uh oh!

gaborbernat Mar 12, 2023

Uh oh!

31z4 Mar 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		.. code-block:: shell

		docker run -v `pwd`:/home/tox/tests -it --rm 31z4/tox run-parallel -e black,py311

Uh oh!

Conversation

31z4 commented Feb 10, 2023

Thanks for contribution

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants