Keep v3 injected environment variable list#2313
Merged
gaborbernat merged 1 commit intotox-dev:rewritefrom Jan 11, 2022
gaborbernat:2259
Merged
Keep v3 injected environment variable list#2313gaborbernat merged 1 commit intotox-dev:rewritefrom gaborbernat:2259
gaborbernat merged 1 commit intotox-dev:rewritefrom
gaborbernat:2259
Conversation
Signed-off-by: Bernát Gábor <[email protected]>
jugmac00
approved these changes
Jan 11, 2022
Comment on lines
+1
to
+2
| Insert ``TOX_WORK_DIR``, ``TOX_ENV_NAME``, ``TOX_ENV_DIR`` and ``VIRTUAL_ENV`` environment variables for each tox | ||
| environments environment variables to keep contract with tox version 3 - by :user:`gaborbernat`. |
Member
There was a problem hiding this comment.
Suggested change
| Insert ``TOX_WORK_DIR``, ``TOX_ENV_NAME``, ``TOX_ENV_DIR`` and ``VIRTUAL_ENV`` environment variables for each tox | |
| environments environment variables to keep contract with tox version 3 - by :user:`gaborbernat`. | |
| Insert ``TOX_WORK_DIR``, ``TOX_ENV_NAME``, ``TOX_ENV_DIR`` and ``VIRTUAL_ENV`` into the environment variables for all tox environments to keep contract with tox version 3 - by :user:`gaborbernat`. |
Member
There was a problem hiding this comment.
What do you think of the updated sentence? The previous one was a bit hard to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2259.