Treat android shells as unix#72
Merged
gaborbernat merged 4 commits intotox-dev:mainfrom Apr 18, 2022
Blocked:treatShellsAsUnix
Merged
Treat android shells as unix#72gaborbernat merged 4 commits intotox-dev:mainfrom Blocked:treatShellsAsUnix
gaborbernat merged 4 commits intotox-dev:mainfrom
Blocked:treatShellsAsUnix
Conversation
Blocked
requested review from
Julian,
RonnyPfannschmidt,
gaborbernat and
ofek
as code owners
ofek
requested changes
Mar 2, 2022
ofek
approved these changes
Mar 2, 2022
gaborbernat
requested changes
Mar 2, 2022
Member
gaborbernat
left a comment
gaborbernat
left a comment
There was a problem hiding this comment.
Holding the merge up as I want to have a think about this design choice 👍
Collaborator
|
@gaborbernat WDYT? |
gaborbernat
approved these changes
Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70 Treats all android shells as unix
Doesn't support custom prefixed development environments as it isn't standardized in any specific android application shell. Custom prefixes if implemented, needs per application check, for each application. I've decided against implementing prefixes as it it's better handled directly by
XDG_*environment variables.