Have duplicate metadata and invalid req strings honor --warn option#357
Merged
kemzeb merged 7 commits intotox-dev:mainfrom Apr 28, 2024
Merged
Have duplicate metadata and invalid req strings honor --warn option#357kemzeb merged 7 commits intotox-dev:mainfrom
kemzeb merged 7 commits intotox-dev:mainfrom
Conversation
Collaborator
Author
|
Still working on this, I'll see if I can finish this and open it for review by the end of today. |
More specifically, the duplicate metadata and invalid req string warnings.
4a4f201 to
e2e0d12
Compare
Collaborator
Author
|
Did a redesign and this seems to be a better implementation than the last. Just need to add coverage tests then I'll open this PR for review |
Collaborator
Author
|
I think this is ready to go, going to open this for review |
Collaborator
Author
|
Here are my design decisions:
|
xiacunshun
reviewed
Apr 27, 2024
Collaborator
|
Ignore my previous deleted comment, I've reconsidered and the handling of "duplicated" here should be fine. |
Collaborator
|
No questions for me here. But I don't have the approve auth, so maybe need to wait for @gaborbernat to take a further look. |
gaborbernat
approved these changes
Apr 28, 2024
Collaborator
Author
|
Great, will release 2.19.0 after merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #355 by making changes and refactors to the warning logic. It does so by introducing a module-level singleton "WarningPrinter" object and refactors the code in such a way to integrate this object for it to be used.