Remove deprecated annotations and Refactor From implementations#608
Merged
jplatte merged 3 commits intotower-rs:mainfrom Dec 3, 2025
Merged
Remove deprecated annotations and Refactor From implementations#608jplatte merged 3 commits intotower-rs:mainfrom
jplatte merged 3 commits intotower-rs:mainfrom
Conversation
jplatte
reviewed
Dec 2, 2025
jplatte
reviewed
Dec 2, 2025
jplatte
reviewed
Dec 2, 2025
tower-http/src/cors/vary.rs
Outdated
Comment on lines
47
to
51
| impl<I> From<I> for Vary | ||
| where | ||
| I: IntoIterator<Item = HeaderName>, | ||
| { | ||
| fn from(iter: I) -> Self { |
…` where possible Remove deprecated `array::IntoIter::new` where `IntoIterator` doesn't fit
47e06ee to
652bef6
Compare
Member
|
Sorry for the delay in reviewing this, and thank you for the contribution! I rebased to see if this still succeeds CI with the changes that have since gone in. But either way I would like to see the blanket-impl changes reverted, as noted above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I saw multiple instances of:
Since the current MSRV is 1.66, these can be simplified.
tower-http/README.md
Line 40 in 35740de
This is not strictly a refactor, I replaced some specific array implementations with a blanket implementation.
Solution
Replaced array-based
Fromimplementations with a generic, iterable-based approachFor
Innerstructs supporting conversions from a single item, I kept the singular conversion method and removed deprecated array handling:This simplifies the code, reduces duplication, and removes no longer necessary
#[allow(deprecated)]annotations.🐱 🧈