Add support for custom status code in TimeoutLayer#599
Merged
jplatte merged 2 commits intotower-rs:mainfrom Oct 14, 2025
Merged
Add support for custom status code in TimeoutLayer#599jplatte merged 2 commits intotower-rs:mainfrom
jplatte merged 2 commits intotower-rs:mainfrom
Conversation
Contributor
Author
|
Hi @jplatte, sorry to ping you, but would you be able to check this PR again? I would like to use this feature soon :) |
Member
|
Always fine to ping me after a week or two of inactivity :) |
jplatte
approved these changes
Oct 14, 2025
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Thanks for your patience! Do you need this in a release?
Contributor
Author
|
Thanks for the review :) a release would be cool, since we can get rid of some custom code, but it's not urgent |
Merged
|
I don't understand why the deprecation of the |
|
I don't think HTTP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Timeoutmiddleware to return HTTP503 Service Unavailablestatus code #579 (comment)TimeoutLayermiddleware allow returning other status codes? #300Solution
TimeoutLayer::newas deprecated