ServeDir to call fallback for invalid filenames (fixes #573)#586
Merged
jplatte merged 10 commits intotower-rs:mainfrom Jun 20, 2025
aryaveersr:main
Merged
ServeDir to call fallback for invalid filenames (fixes #573)#586jplatte merged 10 commits intotower-rs:mainfrom aryaveersr:main
jplatte merged 10 commits intotower-rs:mainfrom
aryaveersr:main
Conversation
aryaveersr
changed the title
jplatte
reviewed
Jun 19, 2025
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Thanks for the PR, especially for including tests!
Co-authored-by: Jonas Platte <[email protected]>
Member
|
One last thing, could you add a changelog entry please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
( See #573 )
ServeDir currently returns ISE for any request involving invalid filenames (eg:
/path|name/). This fixes it so that it instead forwards the request to the fallback (as it should).Solution
This uses a rather ugly solution of manually checking Raw OS error codes for windows. If we ever upgrade MSRV to 1.87 or beyond, we should instead use
io::ErrorKind::InvalidFilename(stabilized in 1.87). I've also put a comment with FIXME regarding this.