Return 0 content length for range requests for empty files#556
Merged
seanmonstar merged 1 commit intotower-rs:mainfrom Apr 9, 2025
Merged
Conversation
seanmonstar
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Also came up here: seanmonstar/reqwest#1559 (comment)
Currently tower-http's
ServeDirhandles range requests for empty files slightly incorrectly, it returns a correctly emptyContent-Rangebut theContent-Lengthis set to1. Which causes troubles inreqwest(it tries to read 1 byte which never comes).For example:
Solution
For empty files, return a content length of 1, instead of calculating it from the inclusive range.