Check that jitter is not NaN instead of finiteness#843
Merged
seanmonstar merged 1 commit intotower-rs:masterfrom Jan 12, 2026
Merged
Check that jitter is not NaN instead of finiteness#843seanmonstar merged 1 commit intotower-rs:masterfrom
jitter is not NaN instead of finiteness#843seanmonstar merged 1 commit intotower-rs:masterfrom
Conversation
Infinities are already covered by the bounds checks on jitter, so checking for finiteness is redundant. We should only need to check for NaN.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Infinities are already covered by the bounds checks on jitter, so checking for finiteness should be redundant. We should only need to check for NaN.