discover: Implement Clone for Change#701
Merged
LucioFranco merged 2 commits intotower-rs:masterfrom Oct 17, 2022
Merged
Conversation
hawkw
reviewed
Oct 13, 2022
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
I think implementing Clone for this seems like a reasonable addition to the API.
Is there a reason that Clone was manually implemented rather than derived?
Implements Clone for discover::Change, if the underlying key and value both implement clone. This is convenient for use-cases where a single change needs to be duplicated, and sent to multiple discover streams.
samvrlewis
force-pushed
the
clone-change
branch
from
34a9e71 to
156219a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Clone for discover::Change, if the underlying key and value both implement clone.
This is convenient for use-cases where a single change is duplicated so that it can be sent to multiple discover streams.