Skip to content

Comments

layer: Implement Layer for tuples of up to 16 elements#694

Merged
davidpdrsn merged 3 commits intotower-rs:masterfrom
jplatte:tuple-layer
Oct 4, 2022
Merged

layer: Implement Layer for tuples of up to 16 elements#694
davidpdrsn merged 3 commits intotower-rs:masterfrom
jplatte:tuple-layer

Conversation

@jplatte
Copy link
Member

@jplatte jplatte commented Sep 28, 2022

@LucioFranco
Copy link
Member

Seems really cool! I would love to seem some examples with it.

@jplatte
Copy link
Member Author

jplatte commented Sep 28, 2022

Okay, I updated the first commit to be more consistent (I had a few TNs instead of LNs) and then added a new commit for the reversed order as dicussed on Discord. Like that, it's easy to reverse-apply the second commit to change the order later, if wanted 🙂

@davidpdrsn
Copy link
Member

Sweet! I can confirm that it matches ServerBuilder now.

@davidpdrsn davidpdrsn added C-enhancement Category: A PR with an enhancement or a proposed on in an issue. A-layer Area: The tower `Layer` trait labels Sep 28, 2022
@jplatte
Copy link
Member Author

jplatte commented Oct 4, 2022

Anything that still needs to happen before this can be merged?

Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope I think it's good to go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-layer Area: The tower `Layer` trait C-enhancement Category: A PR with an enhancement or a proposed on in an issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants